commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henri Yandell" <flame...@gmail.com>
Subject Re: [jira] Resolved: (LANG-421) StringEscapeUtils.escapeJava(String) escapes '/' characters
Date Sun, 11 May 2008 04:59:52 GMT
Note - if this happens, then we should do it from the 2.4 branch.
Trunk is definitely 3.0 land with the MethodUtils stuff added.

We also need to decide if we should rollback the commit as requested by a user.

Hen

On Tue, Apr 8, 2008 at 9:50 PM, Gary Gregory
<GGregory@seagullsoftware.com> wrote:
> My time is limited these days but I should be able to shepherd/RM a 2.4.1.
>
>  I'll look up the laundry list of stuff that needs to be addressed. Feel free to suggest
too ;)
>
>
>  Thank you,
>  Gary
>
>  > -----Original Message-----
>
>
> > From: Henri Yandell [mailto:flamefew@gmail.com]
>  > Sent: Tuesday, April 08, 2008 9:08 PM
>  > To: Commons Developers List
>  > Subject: Re: [jira] Resolved: (LANG-421) StringEscapeUtils.escapeJava(String)
>  > escapes '/' characters
>  >
>  > Sure - if you're up for being the RM :)
>  >
>  > I've a week and a half of freedom left - I suspect it would take a bit
>  > longer to get a 2.4.1 out.
>  >
>  > Hen
>  >
>  > On Wed, Apr 2, 2008 at 2:16 PM, Gary Gregory
>  > <GGregory@seagullsoftware.com> wrote:
>  > > Arg, is there any interest in pushing out a 2.4.1 for this?
>  > >
>  > >  Thank you,
>  > >  Gary
>  > >
>  > >  > -----Original Message-----
>  > >  > From: Gary Gregory (JIRA) [mailto:jira@apache.org]
>  > >  > Sent: Wednesday, April 02, 2008 9:09 AM
>  > >  > To: Gary Gregory
>  > >  > Subject: [jira] Resolved: (LANG-421) StringEscapeUtils.escapeJava(String)
>  > escapes
>  > >  > '/' characters
>  > >  >
>  > >  >
>  > >  >      [ https://issues.apache.org/jira/browse/LANG-
>  > >  > 421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
>  > >  >
>  > >  > Gary Gregory resolved LANG-421.
>  > >  > -------------------------------
>  > >  >
>  > >  >        Resolution: Fixed
>  > >  >     Fix Version/s: Nightly Builds
>  > >  >                    3.0
>  > >  >
>  > >  > Fixed. Added unit test method based on attachment provided.
>  > >  >
>  > >  > > StringEscapeUtils.escapeJava(String) escapes '/' characters
>  > >  > > -----------------------------------------------------------
>  > >  > >
>  > >  > >                 Key: LANG-421
>  > >  > >                 URL: https://issues.apache.org/jira/browse/LANG-421
>  > >  > >             Project: Commons Lang
>  > >  > >          Issue Type: Bug
>  > >  > >    Affects Versions: 2.4
>  > >  > >            Reporter: Steve Hanmann
>  > >  > >            Assignee: Gary Gregory
>  > >  > >            Priority: Blocker
>  > >  > >             Fix For: 3.0, Nightly Builds
>  > >  > >
>  > >  > >         Attachments: StringEscapeUtilsTest.java
>  > >  > >
>  > >  > >
>  > >  > > Commons Lang 2.4 StringEscapeUtils.escapeJava(String) now escapes
'/'
>  > >  > characters, which is not a valid "escapable" character in Java strings.
 I
>  > haven't
>  > >  > tried the other Java escape/unescape methods to see if they have a similar
>  > >  > problem, or that only Java "escapable" characters are escaped by
>  > >  > escapeJava(String).
>  > >  > > This bug may have appeared as an unintended side-effect of the
fix for
>  > LANG-
>  > >  > 363.
>  > >  > > Also the javadoc for escapeJava is now a little off, in that '/'
should now be
>  > >  > included in the sentence describing the differences between Java and
>  > Javascript
>  > >  > strings, with respect to escaping rules.
>  > >  > > The following is a JUnit3 test demonstrating the bug.
>  > >  > > import junit.framework.TestCase;
>  > >  > > import org.apache.commons.lang.StringEscapeUtils;
>  > >  > > public class StringEscapeUtilsTest extends TestCase {
>  > >  > >     public void testEscapeJavaWithSlash() {
>  > >  > >         final String input = "String with a slash (/) in it";
>  > >  > >
>  > >  > >         final String expected = input;
>  > >  > >         final String actual   = StringEscapeUtils.escapeJava( input
);
>  > >  > >         /**
>  > >  > >          * In 2.4 StringEscapeUtils.escapeJava(String) escapes
'/' characters,
>  > >  > >          * which are not a valid character to escape in a Java
string.
>  > >  > >          */
>  > >  > >         assertEquals( expected, actual );
>  > >  > >     }
>  > >  > > }
>  > >  >
>  > >  > --
>  > >  > This message is automatically generated by JIRA.
>  > >  > -
>  > >  > You can reply to this email to add a comment to the issue online.
>  > >
>  > >
>  > >  ---------------------------------------------------------------------
>  > >  To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>  > >  For additional commands, e-mail: dev-help@commons.apache.org
>  > >
>  > >
>  >
>  > ---------------------------------------------------------------------
>  > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>  > For additional commands, e-mail: dev-help@commons.apache.org
>
>
>  ---------------------------------------------------------------------
>  To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>  For additional commands, e-mail: dev-help@commons.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message