commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject Re: [NET] Tabs and spaces
Date Tue, 20 May 2008 19:03:54 GMT
On 20/05/2008, Oberhuber, Martin <Martin.Oberhuber@windriver.com> wrote:
>
>  Is there any guideline on tabs vs spaces in Commons?

Dunno ... my view is that tabs are nothing but trouble, and should
never be used for formatting new code.

>  Given that due to the Copyright Text Change we have
>  A diff on each and every file already, now might be
>  A good time to do such a global cleanup, in order
>  To simplify diffs / patches in upcoming bugfix
>  Releases, and cross-porting patches between the
>  1.5 and 2.0 streams.
>

Yes, indeed.

>  Cheers,
>
> --
>  Martin Oberhuber, Senior Member of Technical Staff, Wind River
>  Target Management Project Lead, DSDP PMC Member
>  http://www.eclipse.org/dsdp/tm
>
>
>
>
>  > -----Original Message-----
>  > From: Dennis Lundberg [mailto:dennisl@apache.org]
>  > Sent: Montag, 19. Mai 2008 19:54
>  > To: Commons Developers List
>  > Subject: Re: [NET] Tabs and spaces
>  >
>  > sebb wrote:
>  > > Looks like most of NET uses spaces for indentation.
>  > >
>  > > [There are about 28,000 lines starting with 4 or more spaces; only
>  > > about 2,000 lines starting with tab]
>  > >
>  > > However, there are quite a few files that use tabs; it
>  > looks like the
>  > > assumption is that tabs are every 4 spaces - but of course
>  > this is not
>  > > necessarily how all editors and printers are set up...
>  > >
>  > > Any views on fixing these?
>  >
>  > I'd replace each tab with 4 spaces.
>  >
>  > > I'm happy to do this.
>  > >
>  > > I noticed the problem when creating some patches for NET.
>  > >
>  > > S///
>  > >
>  > >
>  > ---------------------------------------------------------------------
>  > > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>  > > For additional commands, e-mail: dev-help@commons.apache.org
>  > >
>  > >
>  >
>  >
>  > --
>  > Dennis Lundberg
>  >
>  > ---------------------------------------------------------------------
>  > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>  > For additional commands, e-mail: dev-help@commons.apache.org
>  >
>  >
>
>  ---------------------------------------------------------------------
>  To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>  For additional commands, e-mail: dev-help@commons.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message