commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject Re: [all] Commons SCXML 0.8 RC1 available
Date Sat, 10 May 2008 12:03:31 GMT
On 10/05/2008, Rahul Akolkar <rahul.akolkar@gmail.com> wrote:
> Thanks for your time. Comments below ...
>
>
>  On Fri, May 9, 2008 at 9:00 PM, Niall Pemberton
>  <niall.pemberton@gmail.com> wrote:
>  > The pom.xml had an "empty" <commons.binary.suffix> property (because
>  > the last 0.7 release the binary distro didn't have a suffix) - this
>  > one does though, so I removed that element as the default is "bin" and
>  > I re-generated the download page:
>  > http://svn.apache.org/viewvc?view=rev&revision=654995
>  >
>
> <snip/>
>
>  Great, that works. The release plugin was causing pseudo-updates for
>  the empty element (on release:perform).
>
>
>
>  > Theres a problem with m2 and JDK 1.4 and the ${version} property in
>  > the src assembly descriptor - it picks up some plexus version no. and
>  > so the source distro unpacks to commons-scxml-2.4.1-src. To get round
>  > this you either need to hard code the version number in the source
>  > descriptor (i.e. scr.xml) or use JDK 1.5 to build the release.
>  > see http://markmail.org/message/wqqs67eyi6hq3mcq
>  >
>
> <snap/>
>
>  Fun stuff :-)
>
>  I'll try JDK 1.5 next.
>
>
>
>  > Also I believe the *noise* in the tag commit is caused if "svn up"
>  > hasn't been done after some changes - something to put in the release
>  > notes to do before using the release plugin.
>  >
>
> <snip/>
>
>  Yeah, looks like the noise is the bits I updated today. Will add it to
>  the notes (and remember that before RC2).
>
>  I plan on cutting RC2 mid next week. In the mean time, if anyone has
>  other comments about RC1, please post here.
>

Looks good.

Some very minor nits:

* It would be nice if the source and javadoc manifests had a bit more
detail in them, for example adding the following from the binary
manifest:

Implementation-Title: Commons SCXML
Implementation-Vendor: The Apache Software Foundation
Implementation-Vendor-Id: org.apache
Implementation-Version: 0.8
Specification-Title: Commons SCXML
Specification-Vendor: The Apache Software Foundation
Specification-Version: 0.8

* There's no need for the .asc.sha1 and .asc.md5 digests.

* Building with M1 gives:
DEPRECATED: the default goal should be specified in the <build>
section of project.xml instead of maven.xml
...
java:jar:
    [echo] java:jar is deprecated and will be removed. Please use jar:jar

* Perhaps the M1 build should be deleted?

* The tests generate rather a lot of INFO output.

>
>  -Rahul
>
>
>
>  > Niall
>  >
>  > On Sat, May 10, 2008 at 12:20 AM, Rahul Akolkar <rahul.akolkar@gmail.com>
wrote:
>  >> Distributions, key, release notes, clirr, rat:
>  >>
>  >>  http://people.apache.org/builds/commons/scxml/0.8/RC1/
>  >>
>  >> Site (many links -- such as release docs, some Javadocs; and images
>  >> will remain broken on staging site):
>  >>
>  >>  http://people.apache.org/builds/commons/scxml/0.8/RC1/site/
>  >>
>  >> m2 staging repo:
>  >>
>  >>  http://people.apache.org/builds/commons/scxml/0.8/RC1/staged/
>  >>
>  >> Thanks in advance for all feedback.
>  >>
>  >> This is the first RC using the recent changes to commons-parent. If
>  >> this is successful, I will write up some m2 release docs.
>  >>
>  >> -Rahul
>  >
>
>  ---------------------------------------------------------------------
>  To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>  For additional commands, e-mail: dev-help@commons.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message