Return-Path: Delivered-To: apmail-commons-dev-archive@www.apache.org Received: (qmail 84656 invoked from network); 3 Apr 2008 17:49:49 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 3 Apr 2008 17:49:49 -0000 Received: (qmail 54944 invoked by uid 500); 3 Apr 2008 17:49:47 -0000 Delivered-To: apmail-commons-dev-archive@commons.apache.org Received: (qmail 54882 invoked by uid 500); 3 Apr 2008 17:49:47 -0000 Mailing-List: contact dev-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Jakarta Commons Developers List" Delivered-To: mailing list dev@commons.apache.org Received: (qmail 54872 invoked by uid 99); 3 Apr 2008 17:49:47 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 03 Apr 2008 10:49:47 -0700 X-ASF-Spam-Status: No, hits=1.2 required=10.0 tests=SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (athena.apache.org: local policy) Received: from [64.233.166.182] (HELO py-out-1112.google.com) (64.233.166.182) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 03 Apr 2008 17:49:06 +0000 Received: by py-out-1112.google.com with SMTP id p76so3577040pyb.6 for ; Thu, 03 Apr 2008 10:49:16 -0700 (PDT) Received: by 10.35.38.17 with SMTP id q17mr218507pyj.18.1207244956202; Thu, 03 Apr 2008 10:49:16 -0700 (PDT) Received: by 10.35.131.1 with HTTP; Thu, 3 Apr 2008 10:49:16 -0700 (PDT) Message-ID: Date: Thu, 3 Apr 2008 13:49:16 -0400 From: "James Carman" Sender: jcarman@carmanconsulting.com To: "Jakarta Commons Developers List" Subject: Re: [functor] checkstyle In-Reply-To: <25aac9fc0804031044qcd38b8bvefb6047e7238f370@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <473787.98267.qm@web55106.mail.re4.yahoo.com> <25aac9fc0804031044qcd38b8bvefb6047e7238f370@mail.gmail.com> X-Google-Sender-Auth: 8c6776b2536126fc X-Virus-Checked: Checked by ClamAV on apache.org On Thu, Apr 3, 2008 at 1:44 PM, sebb wrote: > On 03/04/2008, Matt Benson wrote: > > I added checkstyle with a clone from Lang, which is > > pretty permissive. It'd be nice since the project is > > being revived with all new blood, as it were, if we > > could agree on a style that might be a little less > > idiosyncratic (IMO anyway) than the current codebase. > > I propose the following changes, at least to start > > with (my svn diff): > > The only thing I don't like about the current code is that it uses end-of-line left braces. I'm one of the weirdos who likes next-line always. I'm not really familiar with the checkstyle rules, but I can just configure IntelliJ idea accordingly to always format based on those rules. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org For additional commands, e-mail: dev-help@commons.apache.org