Return-Path: Delivered-To: apmail-commons-dev-archive@www.apache.org Received: (qmail 77565 invoked from network); 2 Apr 2008 21:13:41 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 2 Apr 2008 21:13:41 -0000 Received: (qmail 66683 invoked by uid 500); 2 Apr 2008 21:13:39 -0000 Delivered-To: apmail-commons-dev-archive@commons.apache.org Received: (qmail 66582 invoked by uid 500); 2 Apr 2008 21:13:39 -0000 Mailing-List: contact dev-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Jakarta Commons Developers List" Delivered-To: mailing list dev@commons.apache.org Received: (qmail 66572 invoked by uid 500); 2 Apr 2008 21:13:39 -0000 Delivered-To: apmail-jakarta-commons-dev@jakarta.apache.org Received: (qmail 66569 invoked by uid 99); 2 Apr 2008 21:13:39 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 02 Apr 2008 14:13:38 -0700 X-ASF-Spam-Status: No, hits=-4.0 required=10.0 tests=RCVD_IN_DNSWL_MED,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: local policy) Received: from [216.82.250.99] (HELO mail126.messagelabs.com) (216.82.250.99) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 02 Apr 2008 21:12:57 +0000 X-VirusChecked: Checked X-Env-Sender: GGregory@seagullsoftware.com X-Msg-Ref: server-11.tower-126.messagelabs.com!1207170787!1747716!1 X-StarScan-Version: 5.5.12.14.2; banners=-,-,- X-Originating-IP: [137.134.240.188] Received: (qmail 7210 invoked from network); 2 Apr 2008 21:13:07 -0000 Received: from unknown (HELO postal.rocketsoftware.com) (137.134.240.188) by server-11.tower-126.messagelabs.com with RC4-SHA encrypted SMTP; 2 Apr 2008 21:13:07 -0000 Received: from HQMAIL.rocketsoftware.com ([172.16.37.60]) by RS1063.rocketsoftware.com ([172.16.37.63]) with mapi; Wed, 2 Apr 2008 17:13:06 -0400 From: Gary Gregory To: "commons-dev@jakarta.apache.org" Date: Wed, 2 Apr 2008 17:16:42 -0400 Subject: RE: [jira] Resolved: (LANG-421) StringEscapeUtils.escapeJava(String) escapes '/' characters Thread-Topic: [jira] Resolved: (LANG-421) StringEscapeUtils.escapeJava(String) escapes '/' characters Thread-Index: AciU3Dpoe0ZLSHrlT5aCsTW+VHWOZAAKiHVA Message-ID: <94C476C03BFF5E42AC3518FDAC9643C473E30E63C2@HQMAIL.rocketsoftware.com> References: <1384645141.1207152564423.JavaMail.jira@brutus> In-Reply-To: <1384645141.1207152564423.JavaMail.jira@brutus> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Virus-Checked: Checked by ClamAV on apache.org Arg, is there any interest in pushing out a 2.4.1 for this? Thank you, Gary > -----Original Message----- > From: Gary Gregory (JIRA) [mailto:jira@apache.org] > Sent: Wednesday, April 02, 2008 9:09 AM > To: Gary Gregory > Subject: [jira] Resolved: (LANG-421) StringEscapeUtils.escapeJava(String)= escapes > '/' characters > > > [ https://issues.apache.org/jira/browse/LANG- > 421?page=3Dcom.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] > > Gary Gregory resolved LANG-421. > ------------------------------- > > Resolution: Fixed > Fix Version/s: Nightly Builds > 3.0 > > Fixed. Added unit test method based on attachment provided. > > > StringEscapeUtils.escapeJava(String) escapes '/' characters > > ----------------------------------------------------------- > > > > Key: LANG-421 > > URL: https://issues.apache.org/jira/browse/LANG-421 > > Project: Commons Lang > > Issue Type: Bug > > Affects Versions: 2.4 > > Reporter: Steve Hanmann > > Assignee: Gary Gregory > > Priority: Blocker > > Fix For: 3.0, Nightly Builds > > > > Attachments: StringEscapeUtilsTest.java > > > > > > Commons Lang 2.4 StringEscapeUtils.escapeJava(String) now escapes '/' > characters, which is not a valid "escapable" character in Java strings. = I haven't > tried the other Java escape/unescape methods to see if they have a simila= r > problem, or that only Java "escapable" characters are escaped by > escapeJava(String). > > This bug may have appeared as an unintended side-effect of the fix for = LANG- > 363. > > Also the javadoc for escapeJava is now a little off, in that '/' should= now be > included in the sentence describing the differences between Java and Java= script > strings, with respect to escaping rules. > > The following is a JUnit3 test demonstrating the bug. > > import junit.framework.TestCase; > > import org.apache.commons.lang.StringEscapeUtils; > > public class StringEscapeUtilsTest extends TestCase { > > public void testEscapeJavaWithSlash() { > > final String input =3D "String with a slash (/) in it"; > > > > final String expected =3D input; > > final String actual =3D StringEscapeUtils.escapeJava( input )= ; > > /** > > * In 2.4 StringEscapeUtils.escapeJava(String) escapes '/' char= acters, > > * which are not a valid character to escape in a Java string. > > */ > > assertEquals( expected, actual ); > > } > > } > > -- > This message is automatically generated by JIRA. > - > You can reply to this email to add a comment to the issue online. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org For additional commands, e-mail: dev-help@commons.apache.org