commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Matt Benson <gudnabr...@yahoo.com>
Subject Re: [functor] checkstyle
Date Thu, 03 Apr 2008 18:32:26 GMT

--- sebb <sebbaz@gmail.com> wrote:

> On 03/04/2008, Matt Benson <gudnabrsam@yahoo.com>
> wrote:
> > I added checkstyle with a clone from Lang, which
> is
> >  pretty permissive.  It'd be nice since the
> project is
> >  being revived with all new blood, as it were, if
> we
> >  could agree on a style that might be a little
> less
> >  idiosyncratic (IMO anyway) than the current
> codebase.
> >  I propose the following changes, at least to
> start
> >  with (my svn diff):
> >
> >  Index: checkstyle.xml
> > 
>
===================================================================
> >  --- checkstyle.xml      (revision 644344)
> >  +++ checkstyle.xml      (working copy)
> >  @@ -39,5 +39,29 @@
> >      <module name="JavadocMethod">
> >        <property name="allowUndeclaredRTE"
> >  value="true"/>
> >      </module>
> >  - </module>
> >  +
> >  +    <!-- Checks for whitespace
> >        -->
> >  +    <!-- See
> >  http://checkstyle.sf.net/config_whitespace.html
> -->
> >  +    <module name="EmptyForIteratorPad"/>
> 
> Dunno
> 
> >  +    <module name="NoWhitespaceAfter"/>
> 
> Seems a bit drastic. I think it makes sense to ban
> WS after some of
> the tokens mentioned - e.g. DOT - but perhaps not
> ARRAY_INIT BNOT
> LNOT.

Actually I had excluded ARRAY_INIT but undid it for
simplicity's sake.  I have no problem with that one. 
I'm unconvinced on the NOTs, but would be interested
to know what the majority think about it.

-Matt

> 
> >  +    <module name="NoWhitespaceBefore"/>
> 
> OK
> 
> >  +    <module name="OperatorWrap"/>
> 
> OK
> 
> >  +    <module name="TabCharacter"/>
> 
> +1
> 
> >  +    <module name="WhitespaceAfter"/>
> 
> OK
> 
> >  +    <module name="WhitespaceAround"/>
> 
> ?
> 
> >  +    <module name="GenericIllegalRegexp">
> >  +      <property name="format" value="\s+$"/>
> >  +      <property name="message" value="Line has
> >  trailing spaces."/>
> 
> OK
> 
> >  +    </module>
> >  +    <module name="UpperEll"/>
> 
> +1
> 
> >  +    <module name="DeclarationOrder" />
> 
> OK
> 
> >  +    <module name="ModifierOrder" />
> 
> OK
> 
> >  +
> >  +  </module>
> >  +
> >   </module>
> >
> >  This triples the error count, perhaps not
> >  surprisingly.  :)
> >  Any consensus?
> >
> >
> >  -Matt
> >
> >
> >
> >      
>
____________________________________________________________________________________
> >  You rock. That's why Blockbuster's offering you
> one month of Blockbuster Total Access, No Cost.
> > 
> http://tc.deals.yahoo.com/tc/blockbuster/text5.com
> >
> > 
>
---------------------------------------------------------------------
> >  To unsubscribe, e-mail:
> dev-unsubscribe@commons.apache.org
> >  For additional commands, e-mail:
> dev-help@commons.apache.org
> >
> >
> 
>
---------------------------------------------------------------------
> To unsubscribe, e-mail:
> dev-unsubscribe@commons.apache.org
> For additional commands, e-mail:
> dev-help@commons.apache.org
> 
> 



      ____________________________________________________________________________________
You rock. That's why Blockbuster's offering you one month of Blockbuster Total Access, No
Cost.  
http://tc.deals.yahoo.com/tc/blockbuster/text5.com

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message