commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Rory Winston <rory.wins...@gmail.com>
Subject Re: [VOTE] Release Commons Net 2.0
Date Mon, 14 Apr 2008 20:39:28 GMT
Thanks Niklas!
Cheers
Rory
On 8 Apr 2008, at 08:35, Niklas Gustavsson wrote:

> My bad, the branches/NET_2_0 actually gives the following test  
> failures:
>
> Tests in error:
> testInitial(org.apache.commons.net.telnet.TelnetClientTest)
> testOptionNegotiation(org.apache.commons.net.telnet.TelnetClientTest)
> testOptionRenegotiation 
> (org.apache.commons.net.telnet.TelnetClientTest)
> testNotification(org.apache.commons.net.telnet.TelnetClientTest)
> testDeleteOptionHandler 
> (org.apache.commons.net.telnet.TelnetClientTest)
> testAYT(org.apache.commons.net.telnet.TelnetClientTest)
> testSpy(org.apache.commons.net.telnet.TelnetClientTest)
> testSetReaderThread(org.apache.commons.net.telnet.TelnetClientTest)
> testReadOnly(org.apache.commons.net.tftp.TFTPServerPathTest)
> testWriteOnly(org.apache.commons.net.tftp.TFTPServerPathTest)
> testWriteOutsideHome(org.apache.commons.net.tftp.TFTPServerPathTest)
>
> The following patch fixes the TelnetClientTest failures:
>
> Index: src/main/java/org/apache/commons/net/io/ 
> FromNetASCIIInputStream.java
> ===================================================================
> --- src/main/java/org/apache/commons/net/io/ 
> FromNetASCIIInputStream.java	(revision
> 645441)
> +++ src/main/java/org/apache/commons/net/io/ 
> FromNetASCIIInputStream.java	(working
> copy)
> @@ -42,6 +42,7 @@
>
>    static {
>        _lineSeparator = System.getProperty("line.separator");
> +        _lineSeparatorBytes= _lineSeparator.getBytes();
>        _noConversionRequired = _lineSeparator.equals("\r\n");
>    }
>
> Downloading the RC3 build that Rory published, I get the following
> test failure, probably fixable by this patch:
>
> testInitial(org.apache.commons.net.telnet.TelnetClientTest)
> testOptionNegotiation(org.apache.commons.net.telnet.TelnetClientTest)
> testOptionRenegotiation 
> (org.apache.commons.net.telnet.TelnetClientTest)
> testNotification(org.apache.commons.net.telnet.TelnetClientTest)
> testDeleteOptionHandler 
> (org.apache.commons.net.telnet.TelnetClientTest)
> testAYT(org.apache.commons.net.telnet.TelnetClientTest)
> testSpy(org.apache.commons.net.telnet.TelnetClientTest)
> testSetReaderThread(org.apache.commons.net.telnet.TelnetClientTest)
>
> I would love to have a 2.0 release out, but it should build without
> any test failures.
>
> /niklas
>
>
> On Mon, Apr 7, 2008 at 11:58 PM, sebb <sebbaz@gmail.com> wrote:
>> trunk (Java 1.3+)
>>
>> and
>>
>> branches/NET_2_0 (Java 1.5)
>>
>> have the most recent fixes.
>>
>>
>>
>> On 07/04/2008, Niklas Gustavsson <niklas@protocol7.com> wrote:
>>> Hi
>>>
>>> From where is this code built? I've tried building from some  
>>> different
>>> tags and branches, but always get test failures. Here's the  
>>> summaries
>>> and the relevant surefire reports are attached.
>>>
>>> http://svn.apache.org/repos/asf/commons/proper/net/tags/NET_2_0_RC3/
>>>
>>>
>>> Tests in error:
>>> testInitial(org.apache.commons.net.telnet.TelnetClientTest)
>>> testOptionNegotiation 
>>> (org.apache.commons.net.telnet.TelnetClientTest)
>>> testOptionRenegotiation 
>>> (org.apache.commons.net.telnet.TelnetClientTest)
>>> testNotification(org.apache.commons.net.telnet.TelnetClientTest)
>>> testDeleteOptionHandler 
>>> (org.apache.commons.net.telnet.TelnetClientTest)
>>> testAYT(org.apache.commons.net.telnet.TelnetClientTest)
>>> testSpy(org.apache.commons.net.telnet.TelnetClientTest)
>>> testSetReaderThread(org.apache.commons.net.telnet.TelnetClientTest)
>>>
>>>
>>> http://svn.apache.org/repos/asf/commons/proper/net/tags/ 
>>> NET_2_0_RC_3/
>>>
>>>
>>> Tests in error:
>>> testInitial(org.apache.commons.net.telnet.TelnetClientTest)
>>> testOptionNegotiation 
>>> (org.apache.commons.net.telnet.TelnetClientTest)
>>> testOptionRenegotiation 
>>> (org.apache.commons.net.telnet.TelnetClientTest)
>>> testNotification(org.apache.commons.net.telnet.TelnetClientTest)
>>> testDeleteOptionHandler 
>>> (org.apache.commons.net.telnet.TelnetClientTest)
>>> testAYT(org.apache.commons.net.telnet.TelnetClientTest)
>>> testSpy(org.apache.commons.net.telnet.TelnetClientTest)
>>> testSetReaderThread(org.apache.commons.net.telnet.TelnetClientTest)
>>>
>>> testWriteOnly(org.apache.commons.net.tftp.TFTPServerPathTest)
>>> testWriteOutsideHome(org.apache.commons.net.tftp.TFTPServerPathTest)
>>>
>>>
>>> http://svn.apache.org/repos/asf/commons/proper/net/branches/NET_2_0/
>>>
>>> Tests in error:
>>> testWriteOnly(org.apache.commons.net.tftp.TFTPServerPathTest)
>>> testWriteOutsideHome(org.apache.commons.net.tftp.TFTPServerPathTest)
>>>
>>>
>>> /niklas
>>>
>>>
>>>
>>> On Mon, Apr 7, 2008 at 1:12 AM, Rory Winston  
>>> <rory.winston@gmail.com> wrote:
>>>> Hi
>>>>
>>>> This is a release vote for Commons Net 2.0 RC3. This is a
>>>> maintenance release. Thanks to everyone who contributed.
>>>>
>>>> The changes are here:
>>>>
>>>> http://people.apache.org/~rwinston/commons-net-2.0/site/changes-report.html
>>>>
>>>> The RC deployment is here:
>>>> http://people.apache.org/~rwinston/commons-net-2.0/
>>>>
>>>> Javadocs:
>>>> http://people.apache.org/~rwinston/commons-net-2.0/site/apidocs/index.html
>>>>
>>>> have at it!
>>>> Cheers
>>>> Rory
>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>>> For additional commands, e-mail: dev-help@commons.apache.org
>>>>
>>>>
>>>>
>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>>> For additional commands, e-mail: dev-help@commons.apache.org
>>>>
>>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>> For additional commands, e-mail: dev-help@commons.apache.org
>>>
>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message