Mailing-List: contact dev-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Jakarta Commons Developers List" <dev@commons.apache.org>
Received-SPF: pass (athena.apache.org: domain of rory.winston@gmail.com
 designates 72.14.214.228 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:user-agent:mime-version:to:subject:references:in-reply-to:content-type:content-transfer-encoding:from;
        b=lhugldtm8532lROD/EpdAJjvdFgMstb3EGY0Y+vnU/rJtT9270RUgXxhy830kKJQwfq3A+8TxD6VgFZwwSnP72knBX7Z6ea1QwY5GI1+N4FdcAcRcitWu2eQc2h93KKrPjh/AZG6h2nWQNxOx5Ji4g7zuE2+dXMp1PGAaSzL2i8=
Message-ID: <47D2FAA9.5060204@eircom.net>
Date: Sat, 08 Mar 2008 20:44:25 +0000
User-Agent: Thunderbird 2.0.0.12 (Windows/20080213)
MIME-Version: 1.0
To: Jakarta Commons Developers List <dev@commons.apache.org>
Subject: Re: [VOTE] Release Commons Net 1.5
References: <47CB1EBA.6040608@eircom.net>
	 <f2e8eedf0803070804j5d0749cdu2f75db25bab67517@mail.gmail.com>
	 <31cc37360803070917r7147fc3by7c17e6837bafa54e@mail.gmail.com>
 <25aac9fc0803070957i5afb5536s7aeac670ab3f08f4@mail.gmail.com>
In-Reply-To: <25aac9fc0803070957i5afb5536s7aeac670ab3f08f4@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
From: Rory Winston <rory.winston@gmail.com>

I've taken into account the suggestions proposed by various people wrt 
the TFTP server classes and accordingly made some changes. Thanks for 
the feedback.

Rory

sebb wrote:
> On 07/03/2008, Henri Yandell <flamefew@gmail.com> wrote:
>   
>> On Fri, Mar 7, 2008 at 8:04 AM, James Carman <james@carmanconsulting.com> wrote:
>>  > On 3/2/08, Rory Winston <rory.winston@gmail.com> wrote:
>>  >  > Hi
>>  >  >
>>  >  >  This is a release vote for Commons Net 1.5. This release fixes a few
>>  >  >  issues with TFTP errors, threading hangs, and a leap year date parsing bug.
>>  >  >
>>  >  >  The RC deployment is here:
>>  >  >  http://people.apache.org/~rwinston/commons-net-1.5.0/site/
>>  >  >
>>  >  >  Binaries:
>>  >  >
>>  >  >  http://people.apache.org/~rwinston/commons-net-1.5.0/commons-net-1.5.0-SNAPSHOT-bin.zip
>>  >  >
>>  >  >  Source:
>>  >  >
>>  >  >  http://people.apache.org/~rwinston/commons-net-1.5.0/commons-net-1.5.0-SNAPSHOT-src.tar.gz
>>  >  >
>>  >  >  Javadocs:
>>  >  >
>>  >  >  http://people.apache.org/~rwinston/commons-net-1.5.0/site/apidocs/index.html
>>  >  >
>>  >  >  SVN tag:
>>  >  >
>>  >  >  http://svn.apache.org/viewvc/commons/proper/net/tags/NET_1_5_0/
>>  >  >
>>  >  >  Here's my +1 in advance.
>>  >  >  Cheers
>>  >  >  Rory
>>  >  >
>>  >
>>  >  I just wanted to post my official -1 vote.  I feel that the
>>  >  org.apache.commons.net.tftp.TFTPServer class is outside the scope of
>>  >  Commons Net.  I have no problem with it being in the test classes, as
>>  >  suggested, though.
>>
>>
>> Not a problem for me. +1 to including the server class.
>>
>>  It's not big codewise, and is not that far from Net's scope or Commons scope.
>>     
>
> But it's not in scope (yet?)
>
>   
>>  Two proviso's:
>>
>>  1) The main method in TFTPServer should be removed.
>>     
>
> +1
>
>   
>>  2) If we get lots of embedded server components, then we should
>>  rethink this, but I can see that the 'simple embedded server space' is
>>  pretty small. Might want to use a different package to allow it to
>>  more easily be split out.   org.apache.commons.net.server.* or
>>  something. Then people can send in their dumb EchoServer
>>  implementations :)
>>     
>
> +1 to changing package name.
>
> I still think it should be in the test tree; AFAICS the purpose of the
> code contribution was to enable the TFTP Client to be tested.
>
> If Commons starts getting other simple server implementations then
> these ought to be part of a different project with a scope of
> Testing/Mocking or some such. Maybe not even in Commons.
>
>   
>>  Hen
>>
>>
>>  ---------------------------------------------------------------------
>>  To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>  For additional commands, e-mail: dev-help@commons.apache.org
>>
>>
>>     
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
>
>
>   


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org