Return-Path: Delivered-To: apmail-commons-dev-archive@www.apache.org Received: (qmail 74180 invoked from network); 23 Mar 2008 14:41:15 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 23 Mar 2008 14:41:15 -0000 Received: (qmail 23979 invoked by uid 500); 23 Mar 2008 14:41:12 -0000 Delivered-To: apmail-commons-dev-archive@commons.apache.org Received: (qmail 23899 invoked by uid 500); 23 Mar 2008 14:41:12 -0000 Mailing-List: contact dev-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Jakarta Commons Developers List" Delivered-To: mailing list dev@commons.apache.org Received: (qmail 23890 invoked by uid 99); 23 Mar 2008 14:41:12 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 23 Mar 2008 07:41:12 -0700 X-ASF-Spam-Status: No, hits=2.0 required=10.0 tests=HTML_MESSAGE,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of loompa@gmail.com designates 209.85.200.168 as permitted sender) Received: from [209.85.200.168] (HELO wf-out-1314.google.com) (209.85.200.168) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 23 Mar 2008 14:40:33 +0000 Received: by wf-out-1314.google.com with SMTP id 25so2362212wfc.27 for ; Sun, 23 Mar 2008 07:40:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:references; bh=pbFW9y4QZIyTLqjMlEceItmpR/gLRQZMtaf6lmwNce4=; b=ivlujshlgzeGxUEHFPmtHFuHU0/PGqkN3Joq3rDfgkTf4Yw7lxvaQIWU5WFZNmhXXnC9ovFvN+mUr117Rk+hHwcOpUDkqIe6cSGv/rr1ph3C16dlPu79kJpyMw3VYTZwYn65GD6C+ij9VkWGBT7A010t/I3xIUpQ3/CpnERlJfw= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=message-id:date:from:to:subject:in-reply-to:mime-version:content-type:references; b=MjX/oQhe3qijcAj11H+TtfxdkxsAI4kmTKXoB3ak/Z0PE0onzoVry4zsnFz5f3RHH0bMNYli4mmaJRV1x8RDR8gFaMsM4SPCLpniB1zFJ6isYwGqptGcxP5bwD/HVQQbMstXTwd365TXIMCxjgbGnGAz2zfCjMCsrxpccUyMp/c= Received: by 10.115.61.1 with SMTP id o1mr9739063wak.94.1206283245055; Sun, 23 Mar 2008 07:40:45 -0700 (PDT) Received: by 10.114.110.5 with HTTP; Sun, 23 Mar 2008 07:40:44 -0700 (PDT) Message-ID: <1e379fc30803230740g4d5c1cb8oc1a00c09d2d5b969@mail.gmail.com> Date: Sun, 23 Mar 2008 14:40:44 +0000 From: "Dave Meikle" To: "Jakarta Commons Developers List" Subject: Re: [collections] 3.3 issues In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="----=_Part_4450_10464962.1206283245042" References: <31cc37360803182335o280f55c2vabc7154da6d369db@mail.gmail.com> X-Virus-Checked: Checked by ClamAV on apache.org ------=_Part_4450_10464962.1206283245042 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline On 19/03/2008, James Carman wrote: > > On 3/19/08, Henri Yandell wrote: > > > * Specifically for James Carman - how does Dave's patch to your > > COLLECTIONS-194 look? > > I would rather see it with the nopTransformer(), personally. This > would remove the null checks from the implementation method (the one > that takes all of the parameters). I actually had this code lying > around and I don't know why I didn't do the work to patch it myself. > I have updated the patch to include James's suggested improvements. Cheers, Dave ------=_Part_4450_10464962.1206283245042--