From dev-return-107675-apmail-commons-dev-archive=commons.apache.org@commons.apache.org Mon Mar 03 10:52:41 2008 Return-Path: Delivered-To: apmail-commons-dev-archive@www.apache.org Received: (qmail 44779 invoked from network); 3 Mar 2008 10:52:40 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 3 Mar 2008 10:52:40 -0000 Received: (qmail 7932 invoked by uid 500); 3 Mar 2008 10:52:34 -0000 Delivered-To: apmail-commons-dev-archive@commons.apache.org Received: (qmail 7876 invoked by uid 500); 3 Mar 2008 10:52:34 -0000 Mailing-List: contact dev-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Jakarta Commons Developers List" Delivered-To: mailing list dev@commons.apache.org Received: (qmail 7867 invoked by uid 99); 3 Mar 2008 10:52:34 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 03 Mar 2008 02:52:34 -0800 X-ASF-Spam-Status: No, hits=-1.0 required=10.0 tests=RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: local policy) Received: from [147.11.1.11] (HELO mail.wrs.com) (147.11.1.11) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 03 Mar 2008 10:51:43 +0000 Received: from ALA-MAIL03.corp.ad.wrs.com (ala-mail03 [147.11.57.144]) by mail.wrs.com (8.13.6/8.13.6) with ESMTP id m23Aq0kA005031 for ; Mon, 3 Mar 2008 02:52:00 -0800 (PST) Received: from ism-mail03.corp.ad.wrs.com ([128.224.200.20]) by ALA-MAIL03.corp.ad.wrs.com with Microsoft SMTPSVC(6.0.3790.1830); Mon, 3 Mar 2008 02:50:22 -0800 X-MimeOLE: Produced By Microsoft Exchange V6.5 Content-class: urn:content-classes:message MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Subject: RE: [VOTE] Release Commons Net 1.5 Date: Mon, 3 Mar 2008 11:50:19 +0100 Message-ID: <460801A4097E3D4CA04CC64EE648584804A829AC@ism-mail03.corp.ad.wrs.com> In-Reply-To: <47CB1EBA.6040608@eircom.net> X-MS-Has-Attach: X-MS-TNEF-Correlator: Thread-Topic: [VOTE] Release Commons Net 1.5 Thread-Index: Ach88pCsoVouS3FMQnCBWL8LYSXZeQAH8nFw References: <47CB1EBA.6040608@eircom.net> From: "Oberhuber, Martin" To: "Jakarta Commons Developers List" X-OriginalArrivalTime: 03 Mar 2008 10:50:22.0399 (UTC) FILETIME=[613CCCF0:01C87D1C] X-Virus-Checked: Checked by ClamAV on apache.org Hi Rory, it's great to hear some progress is being made towards a new commons.net release!!! For the 1.5 release candidate, I notice that the binary JAR now has the examples classes embedded whereas the 1.4=20 release did not. Also, some Maven POM stuff is in META-INF. Is this intentional? jar tfv commons-net-1.4.1.jar | awk '{print $8;}' | sort > cn141.txt jar tfv commons-net-1.5.0*.jar | awk '{print $8;}' | sort > cn150.txt diff cn150.txt cn141.txt 5,39d4 < META-INF/maven/ < META-INF/maven/commons-net/ < META-INF/maven/commons-net/commons-net/ < META-INF/maven/commons-net/commons-net/pom.properties < META-INF/maven/commons-net/commons-net/pom.xml < examples/ < examples/IOUtil.class [...] < examples/tftp.class < examples/weatherTelnet.class 97d61 < org/apache/commons/net/ftp/parser/NetwareFTPEntryParser.class 179,180d142 < org/apache/commons/net/tftp/TFTPServer$TFTPTransfer.class < org/apache/commons/net/tftp/TFTPServer.class Also, your Source Package includes some odd files which I=20 believe should not be part of a release: the "proposal" did not make it into the binary release, and "src/assembly" has not been part of 1.4.1: /propsal/ftp2/ /src/assembly/ /src/java/org/apache/commons/net/tftp/ -! (DIR) TFTPClient-1.4.1-fix.diff TFTPClient.java.orig TFTPClient.java.rej =20 The other thing I'd REALLY consider important especially for a 1.5.x service release, is a list of changes that were made.=20 Is such a changelog available anywhere? I tried making a source diff, but it throws out ALL files as different since the copyright headers changed. I think that=20 the change in copyright terms might also be worth mentioning in the change log. More changes were indicated due to RCS Version tags like * @version $Id: .*$ or * @version $Revision: .*$ That being said, I noticed that the following file(s) do *NOT* carry the new license header in 1.5: TFTPClient.java and others e.g. TimeTCPClientTest.java did even carry an Apache 1.1 license in version 1.4, or no license at all (AllTests.java). Also, is it legally OK to omit the Copyright Years? In 1.4.1, some files were Copyright 2001-2005 while others (especially Telnet) were Copyright 2003-2004 while others (FTPParser)=20 were Copyright 2004 or Copyright 2005. In UnixFTPEntryParserTest.java I see that one test case is commented out, is this intentional? In build.xml you still have this, I think it should not be -dev: I made some semi-automated editing on the source archives, and came up with following list of files that were changed for 1.5.0 -- perhaps it helps finding the bugs that were resolved for 1.5.0, in order to compile a change list: diff -r -b = commons-net-1.4.1/src/java/org/apache/commons/net/ftp/FTP.java=20 diff -r -b = commons-net-1.4.1/src/java/org/apache/commons/net/ftp/FTPClient.java=20 diff -r -b = commons-net-1.4.1/src/java/org/apache/commons/net/ftp/FTPClientConfig.jav= a=20 diff -r -b = commons-net-1.4.1/src/java/org/apache/commons/net/ftp/parser/DefaultFTPFi= leEntryParserFactory.java=20 diff -r -b = commons-net-1.4.1/src/java/org/apache/commons/net/ftp/parser/FTPTimestamp= ParserImpl.java=20 diff -r -b = commons-net-1.4.1/src/java/org/apache/commons/net/ftp/parser/NTFTPEntryPa= rser.java=20 Only in = commons-net-1.5.0-SNAPSHOT-src/src/java/org/apache/commons/net/ftp/parser= : NetwareFTPEntryParser.java diff -r -b = commons-net-1.4.1/src/java/org/apache/commons/net/ftp/parser/UnixFTPEntry= Parser.java=20 diff -r -b = commons-net-1.4.1/src/java/org/apache/commons/net/nntp/Article.java=20 diff -r -b = commons-net-1.4.1/src/java/org/apache/commons/net/telnet/TelnetInputStrea= m.java=20 diff -r -b = commons-net-1.4.1/src/java/org/apache/commons/net/tftp/TFTPClient.java=20 Only in = commons-net-1.5.0-SNAPSHOT-src/src/java/org/apache/commons/net/tftp: = TFTPServer.java Only in commons-net-1.4.1/target: test-classes Only in commons-net-1.5.0-SNAPSHOT-src: xdocs Cheers, -- Martin Oberhuber, Senior Member of Technical Staff, Wind River Target Management Project Lead, DSDP PMC Member http://www.eclipse.org/dsdp/tm =20 =20 > -----Original Message----- > From: Rory Winston [mailto:rory.winston@gmail.com]=20 > Sent: Sonntag, 02. M=E4rz 2008 22:40 > To: Jakarta Commons Developers List > Subject: [VOTE] Release Commons Net 1.5 >=20 > Hi >=20 > This is a release vote for Commons Net 1.5. This release fixes a few=20 > issues with TFTP errors, threading hangs, and a leap year=20 > date parsing bug. >=20 > The RC deployment is here: > http://people.apache.org/~rwinston/commons-net-1.5.0/site/ >=20 > Binaries: >=20 > http://people.apache.org/~rwinston/commons-net-1.5.0/commons-n > et-1.5.0-SNAPSHOT-bin.zip >=20 > Source: >=20 > http://people.apache.org/~rwinston/commons-net-1.5.0/commons-n > et-1.5.0-SNAPSHOT-src.tar.gz >=20 > Javadocs: >=20 > http://people.apache.org/~rwinston/commons-net-1.5.0/site/apid > ocs/index.html >=20 > SVN tag: >=20 > http://svn.apache.org/viewvc/commons/proper/net/tags/NET_1_5_0/ >=20 > Here's my +1 in advance. > Cheers > Rory >=20 > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org > For additional commands, e-mail: dev-help@commons.apache.org >=20 >=20 --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org For additional commands, e-mail: dev-help@commons.apache.org