commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Niall Pemberton" <niall.pember...@gmail.com>
Subject Re: svn commit: r638703 - in /commons/proper/lang/branches/LANG_POST_2_4/src: java/org/apache/commons/lang/ test/org/apache/commons/lang/
Date Wed, 19 Mar 2008 15:54:35 GMT
On Wed, Mar 19, 2008 at 2:42 PM, Matt Benson <gudnabrsam@yahoo.com> wrote:
>
>  --- Rahul Akolkar <rahul.akolkar@gmail.com> wrote:
>
>  > On 3/19/08, Matt Benson <gudnabrsam@yahoo.com>
>  > wrote:
>  > >
>  > >  --- Niall Pemberton <niall.pemberton@gmail.com>
>  > wrote:
>  > >
>  > >  > Adding rather than copying looses all the svn
>  > >  > history of these files
>  > >  > which is a big mistake IMO.
>  > >
>  > >
>  > > Point taken; I wasn't thinking about that.  :)
>  > >  However, since we've not yet agreed on the final
>  > home
>  > >  for this stuff, I'm going to leave as-is for now.
>  >  If
>  > >  we decide to merge this stuff back to trunk (this
>  > is
>  > >  intended, after all, to be only a temporary
>  > branch),
>  > >  we can copy the (non-compiling) BeanUtils
>  > versions in,
>  > >  then Lang-ify by committing the branch versions.
>  > >
>  > <snip/>
>  >
>  > This will make it hard to carry over the history
>  > between now and then, if any.
>
>  Okay.  You guys win.  I'll try to get to it today.

Great, thanks :)

Another suggestion - perhaps these things should go in a
"org.apache.commons.lang.reflect" package? It would tie up nicely with
the java.lang.reflect and package all these related impls. together.

Niall

>  -Matt
>
>
>  >
>  > -Rahul
>  >
>  >
>  >
>  > >  Also, I didn't reuse the old tests at all, but if
>  > you
>  > >  think it's important that we do so let me know.
>  > >
>  > >  -Matt
>  > >
>  > <snap/>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message