commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Oberhuber, Martin" <Martin.Oberhu...@windriver.com>
Subject RE: [VOTE] Release Commons Net 1.5
Date Mon, 03 Mar 2008 10:50:19 GMT
Hi Rory,

it's great to hear some progress is being made towards a new
commons.net release!!!

For the 1.5 release candidate, I notice that the binary
JAR now has the examples classes embedded whereas the 1.4 
release did not. Also, some Maven POM stuff is in META-INF.
Is this intentional?

jar tfv commons-net-1.4.1.jar | awk '{print $8;}' | sort > cn141.txt
jar tfv commons-net-1.5.0*.jar | awk '{print $8;}' | sort > cn150.txt
diff cn150.txt cn141.txt

5,39d4
< META-INF/maven/
< META-INF/maven/commons-net/
< META-INF/maven/commons-net/commons-net/
< META-INF/maven/commons-net/commons-net/pom.properties
< META-INF/maven/commons-net/commons-net/pom.xml
< examples/
< examples/IOUtil.class
[...]
< examples/tftp.class
< examples/weatherTelnet.class
97d61
< org/apache/commons/net/ftp/parser/NetwareFTPEntryParser.class
179,180d142
< org/apache/commons/net/tftp/TFTPServer$TFTPTransfer.class
< org/apache/commons/net/tftp/TFTPServer.class

Also, your Source Package includes some odd files which I 
believe should not be part of a release: the "proposal" did
not make it into the binary release, and "src/assembly" has
not been part of 1.4.1:
   /propsal/ftp2/
   /src/assembly/
   /src/java/org/apache/commons/net/tftp/
      -! (DIR)
      TFTPClient-1.4.1-fix.diff
      TFTPClient.java.orig
      TFTPClient.java.rej
      

The other thing I'd REALLY consider important especially for a
1.5.x service release, is a list of changes that were made. 
Is such a changelog available anywhere?

I tried making a source diff, but it throws out ALL files as
different since the copyright headers changed. I think that 
the change in copyright terms might also be worth mentioning
in the change log. More changes were indicated due to RCS
Version tags like  * @version $Id: .*$
or * @version $Revision: .*$

That being said, I noticed that the following file(s) do *NOT*
carry the new license header in 1.5:
   TFTPClient.java
and others e.g. TimeTCPClientTest.java did even carry an
Apache 1.1 license in version 1.4, or no license at all
(AllTests.java).

Also, is it legally OK to omit the Copyright Years? In 1.4.1,
some files were Copyright 2001-2005 while others (especially
Telnet) were Copyright 2003-2004 while others (FTPParser) 
were Copyright 2004 or Copyright 2005.

In UnixFTPEntryParserTest.java I see that one test case is
commented out, is this intentional?

In build.xml you still have this, I think it should not be -dev:
   <property name="final.name" value="commons-net-1.5.0-dev">

I made some semi-automated editing on the source archives,
and came up with following list of files that were changed
for 1.5.0 -- perhaps it helps finding the bugs that were
resolved for 1.5.0, in order to compile a change list:

diff -r -b commons-net-1.4.1/src/java/org/apache/commons/net/ftp/FTP.java 
diff -r -b commons-net-1.4.1/src/java/org/apache/commons/net/ftp/FTPClient.java 
diff -r -b commons-net-1.4.1/src/java/org/apache/commons/net/ftp/FTPClientConfig.java 
diff -r -b commons-net-1.4.1/src/java/org/apache/commons/net/ftp/parser/DefaultFTPFileEntryParserFactory.java

diff -r -b commons-net-1.4.1/src/java/org/apache/commons/net/ftp/parser/FTPTimestampParserImpl.java

diff -r -b commons-net-1.4.1/src/java/org/apache/commons/net/ftp/parser/NTFTPEntryParser.java

Only in commons-net-1.5.0-SNAPSHOT-src/src/java/org/apache/commons/net/ftp/parser: NetwareFTPEntryParser.java
diff -r -b commons-net-1.4.1/src/java/org/apache/commons/net/ftp/parser/UnixFTPEntryParser.java

diff -r -b commons-net-1.4.1/src/java/org/apache/commons/net/nntp/Article.java 
diff -r -b commons-net-1.4.1/src/java/org/apache/commons/net/telnet/TelnetInputStream.java

diff -r -b commons-net-1.4.1/src/java/org/apache/commons/net/tftp/TFTPClient.java 
Only in commons-net-1.5.0-SNAPSHOT-src/src/java/org/apache/commons/net/tftp: TFTPServer.java

Only in commons-net-1.4.1/target: test-classes
Only in commons-net-1.5.0-SNAPSHOT-src: xdocs

Cheers,
--
Martin Oberhuber, Senior Member of Technical Staff, Wind River
Target Management Project Lead, DSDP PMC Member
http://www.eclipse.org/dsdp/tm
 
 

> -----Original Message-----
> From: Rory Winston [mailto:rory.winston@gmail.com] 
> Sent: Sonntag, 02. März 2008 22:40
> To: Jakarta Commons Developers List
> Subject: [VOTE] Release Commons Net 1.5
> 
> Hi
> 
> This is a release vote for Commons Net 1.5. This release fixes a few 
> issues with TFTP errors, threading hangs, and a leap year 
> date parsing bug.
> 
> The RC deployment is here:
> http://people.apache.org/~rwinston/commons-net-1.5.0/site/
> 
> Binaries:
> 
> http://people.apache.org/~rwinston/commons-net-1.5.0/commons-n
> et-1.5.0-SNAPSHOT-bin.zip
> 
> Source:
> 
> http://people.apache.org/~rwinston/commons-net-1.5.0/commons-n
> et-1.5.0-SNAPSHOT-src.tar.gz
> 
> Javadocs:
> 
> http://people.apache.org/~rwinston/commons-net-1.5.0/site/apid
> ocs/index.html
> 
> SVN tag:
> 
> http://svn.apache.org/viewvc/commons/proper/net/tags/NET_1_5_0/
> 
> Here's my +1 in advance.
> Cheers
> Rory
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
> 
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message