commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject Re: [VOTE] Release Commons Net 1.5
Date Wed, 12 Mar 2008 10:19:49 GMT
On 12/03/2008, Oberhuber, Martin <Martin.Oberhuber@windriver.com> wrote:
> What about using ftp.microsoft.com for the Windows Tests?

I think that should be run past the PMC - is it fair to use another
company's resources in this way? I know it's not likely to generate a
big load, but including another organisation's details in test code
does not seem entirely fair.

>  They should be available quite reliably, eh? And it's very
>  likely that they will keep using a Windows FTP server rather
>  than switching to UNIX.
>
>  Y:\>ftp ftp.microsoft.com
>  Connected to ftp.microsoft.com.
>  220 Microsoft FTP Service
>  User (ftp.microsoft.com:(none)): anonymous
>  331 Anonymous access allowed, send identity (e-mail name) as password.
>  Password:
>  230 Anonymous user logged in.
>  ftp> literal syst
>  215 Windows_NT
>  ftp> literal feat
>  211-FEAT
>     SIZE
>     MDTM
>  211 END
>
>
>  Cheers,
>  --
>  Martin Oberhuber, Senior Member of Technical Staff, Wind River
>  Target Management Project Lead, DSDP PMC Member
>  http://www.eclipse.org/dsdp/tm
>
>
>
>  > -----Original Message-----
>
> > From: Rory Winston [mailto:rory.winston@gmail.com]
>
> > Sent: Samstag, 08. März 2008 21:39
>  > To: Jakarta Commons Developers List
>
> > Subject: Re: [VOTE] Release Commons Net 1.5
>  >
>  > The functional tests seem to be broken right now, due to the remote
>  > server being unavailable. These don't get run by default
>  > anyways, so I
>  > think we should just leave this for now, unless someone can suggest a
>  > different server.
>  >
>  > Rory
>  >
>  > Oberhuber, Martin wrote:
>  > > Also, I get unit test failures in
>  > >    FTPClientConfigFunctionalTest.testTimeZoneFunctionality()
>  > > as well as all FTP Windows tests (looks like ftp.wacom.com
>  > > is down -- should a different Windows FTP Server be added?)
>  > >
>  > > Cheers,
>  > > --
>  > > Martin Oberhuber, Senior Member of Technical Staff, Wind River
>  > > Target Management Project Lead, DSDP PMC Member
>  > > http://www.eclipse.org/dsdp/tm
>  > >
>  > >
>  > >
>  > >
>  > >> -----Original Message-----
>  > >> From: Oberhuber, Martin
>  > >> Sent: Montag, 03. März 2008 11:50
>  > >> To: 'Jakarta Commons Developers List'
>  > >> Subject: RE: [VOTE] Release Commons Net 1.5
>  > >>
>  > >> Hi Rory,
>  > >>
>  > >> it's great to hear some progress is being made towards a new
>  > >> commons.net release!!!
>  > >>
>  > >> For the 1.5 release candidate, I notice that the binary
>  > >> JAR now has the examples classes embedded whereas the 1.4
>  > >> release did not. Also, some Maven POM stuff is in META-INF.
>  > >> Is this intentional?
>  > >>
>  > >> jar tfv commons-net-1.4.1.jar | awk '{print $8;}' | sort >
>  > cn141.txt
>  > >> jar tfv commons-net-1.5.0*.jar | awk '{print $8;}' | sort
>  > > cn150.txt
>  > >> diff cn150.txt cn141.txt
>  > >>
>  > >> 5,39d4
>  > >> < META-INF/maven/
>  > >> < META-INF/maven/commons-net/
>  > >> < META-INF/maven/commons-net/commons-net/
>  > >> < META-INF/maven/commons-net/commons-net/pom.properties
>  > >> < META-INF/maven/commons-net/commons-net/pom.xml
>  > >> < examples/
>  > >> < examples/IOUtil.class
>  > >> [...]
>  > >> < examples/tftp.class
>  > >> < examples/weatherTelnet.class
>  > >> 97d61
>  > >> < org/apache/commons/net/ftp/parser/NetwareFTPEntryParser.class
>  > >> 179,180d142
>  > >> < org/apache/commons/net/tftp/TFTPServer$TFTPTransfer.class
>  > >> < org/apache/commons/net/tftp/TFTPServer.class
>  > >>
>  > >> Also, your Source Package includes some odd files which I
>  > >> believe should not be part of a release: the "proposal" did
>  > >> not make it into the binary release, and "src/assembly" has
>  > >> not been part of 1.4.1:
>  > >>    /propsal/ftp2/
>  > >>    /src/assembly/
>  > >>    /src/java/org/apache/commons/net/tftp/
>  > >>       -! (DIR)
>  > >>       TFTPClient-1.4.1-fix.diff
>  > >>       TFTPClient.java.orig
>  > >>       TFTPClient.java.rej
>  > >>
>  > >>
>  > >> The other thing I'd REALLY consider important especially for a
>  > >> 1.5.x service release, is a list of changes that were made.
>  > >> Is such a changelog available anywhere?
>  > >>
>  > >> I tried making a source diff, but it throws out ALL files as
>  > >> different since the copyright headers changed. I think that
>  > >> the change in copyright terms might also be worth mentioning
>  > >> in the change log. More changes were indicated due to RCS
>  > >> Version tags like  * @version $Id: .*$
>  > >> or * @version $Revision: .*$
>  > >>
>  > >> That being said, I noticed that the following file(s) do *NOT*
>  > >> carry the new license header in 1.5:
>  > >>    TFTPClient.java
>  > >> and others e.g. TimeTCPClientTest.java did even carry an
>  > >> Apache 1.1 license in version 1.4, or no license at all
>  > >> (AllTests.java).
>  > >>
>  > >> Also, is it legally OK to omit the Copyright Years? In 1.4.1,
>  > >> some files were Copyright 2001-2005 while others (especially
>  > >> Telnet) were Copyright 2003-2004 while others (FTPParser)
>  > >> were Copyright 2004 or Copyright 2005.
>  > >>
>  > >> In UnixFTPEntryParserTest.java I see that one test case is
>  > >> commented out, is this intentional?
>  > >>
>  > >> In build.xml you still have this, I think it should not be -dev:
>  > >>    <property name="final.name" value="commons-net-1.5.0-dev">
>  > >>
>  > >> I made some semi-automated editing on the source archives,
>  > >> and came up with following list of files that were changed
>  > >> for 1.5.0 -- perhaps it helps finding the bugs that were
>  > >> resolved for 1.5.0, in order to compile a change list:
>  > >>
>  > >> diff -r -b
>  > >> commons-net-1.4.1/src/java/org/apache/commons/net/ftp/FTP.java
>  > >> diff -r -b
>  > >>
>  > commons-net-1.4.1/src/java/org/apache/commons/net/ftp/FTPClient.java
>  > >> diff -r -b
>  > >> commons-net-1.4.1/src/java/org/apache/commons/net/ftp/FTPClien
>  > >> tConfig.java
>  > >> diff -r -b
>  > >> commons-net-1.4.1/src/java/org/apache/commons/net/ftp/parser/D
>  > >> efaultFTPFileEntryParserFactory.java
>  > >> diff -r -b
>  > >> commons-net-1.4.1/src/java/org/apache/commons/net/ftp/parser/F
>  > >> TPTimestampParserImpl.java
>  > >> diff -r -b
>  > >> commons-net-1.4.1/src/java/org/apache/commons/net/ftp/parser/N
>  > >> TFTPEntryParser.java
>  > >> Only in
>  > >> commons-net-1.5.0-SNAPSHOT-src/src/java/org/apache/commons/net
>  > >> /ftp/parser: NetwareFTPEntryParser.java
>  > >> diff -r -b
>  > >> commons-net-1.4.1/src/java/org/apache/commons/net/ftp/parser/U
>  > >> nixFTPEntryParser.java
>  > >> diff -r -b
>  > >>
>  > commons-net-1.4.1/src/java/org/apache/commons/net/nntp/Article.java
>  > >> diff -r -b
>  > >> commons-net-1.4.1/src/java/org/apache/commons/net/telnet/Telne
>  > >> tInputStream.java
>  > >> diff -r -b
>  > >> commons-net-1.4.1/src/java/org/apache/commons/net/tftp/TFTPCli
>  > >> ent.java
>  > >> Only in
>  > >> commons-net-1.5.0-SNAPSHOT-src/src/java/org/apache/commons/net
>  > >> /tftp: TFTPServer.java
>  > >>
>  > >> Only in commons-net-1.4.1/target: test-classes
>  > >> Only in commons-net-1.5.0-SNAPSHOT-src: xdocs
>  > >>
>  > >> Cheers,
>  > >> --
>  > >> Martin Oberhuber, Senior Member of Technical Staff, Wind River
>  > >> Target Management Project Lead, DSDP PMC Member
>  > >> http://www.eclipse.org/dsdp/tm
>  > >>
>  > >
>  > >
>  > ---------------------------------------------------------------------
>  > > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>  > > For additional commands, e-mail: dev-help@commons.apache.org
>  > >
>  > >
>  > >
>  > >
>  > >
>  >
>  >
>  > ---------------------------------------------------------------------
>  > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>  > For additional commands, e-mail: dev-help@commons.apache.org
>  >
>  >
>
>  ---------------------------------------------------------------------
>  To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>  For additional commands, e-mail: dev-help@commons.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message