commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject Re: [VOTE] Release Commons Net 1.5
Date Fri, 07 Mar 2008 17:57:12 GMT
On 07/03/2008, Henri Yandell <flamefew@gmail.com> wrote:
> On Fri, Mar 7, 2008 at 8:04 AM, James Carman <james@carmanconsulting.com> wrote:
>  > On 3/2/08, Rory Winston <rory.winston@gmail.com> wrote:
>  >  > Hi
>  >  >
>  >  >  This is a release vote for Commons Net 1.5. This release fixes a few
>  >  >  issues with TFTP errors, threading hangs, and a leap year date parsing bug.
>  >  >
>  >  >  The RC deployment is here:
>  >  >  http://people.apache.org/~rwinston/commons-net-1.5.0/site/
>  >  >
>  >  >  Binaries:
>  >  >
>  >  >  http://people.apache.org/~rwinston/commons-net-1.5.0/commons-net-1.5.0-SNAPSHOT-bin.zip
>  >  >
>  >  >  Source:
>  >  >
>  >  >  http://people.apache.org/~rwinston/commons-net-1.5.0/commons-net-1.5.0-SNAPSHOT-src.tar.gz
>  >  >
>  >  >  Javadocs:
>  >  >
>  >  >  http://people.apache.org/~rwinston/commons-net-1.5.0/site/apidocs/index.html
>  >  >
>  >  >  SVN tag:
>  >  >
>  >  >  http://svn.apache.org/viewvc/commons/proper/net/tags/NET_1_5_0/
>  >  >
>  >  >  Here's my +1 in advance.
>  >  >  Cheers
>  >  >  Rory
>  >  >
>  >
>  >  I just wanted to post my official -1 vote.  I feel that the
>  >  org.apache.commons.net.tftp.TFTPServer class is outside the scope of
>  >  Commons Net.  I have no problem with it being in the test classes, as
>  >  suggested, though.
>
>
> Not a problem for me. +1 to including the server class.
>
>  It's not big codewise, and is not that far from Net's scope or Commons scope.

But it's not in scope (yet?)

>  Two proviso's:
>
>  1) The main method in TFTPServer should be removed.

+1

>  2) If we get lots of embedded server components, then we should
>  rethink this, but I can see that the 'simple embedded server space' is
>  pretty small. Might want to use a different package to allow it to
>  more easily be split out.   org.apache.commons.net.server.* or
>  something. Then people can send in their dumb EchoServer
>  implementations :)

+1 to changing package name.

I still think it should be in the test tree; AFAICS the purpose of the
code contribution was to enable the TFTP Client to be tested.

If Commons starts getting other simple server implementations then
these ought to be part of a different project with a scope of
Testing/Mocking or some such. Maybe not even in Commons.

>  Hen
>
>
>  ---------------------------------------------------------------------
>  To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>  For additional commands, e-mail: dev-help@commons.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message