Mailing-List: contact dev-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Jakarta Commons Developers List" <dev@commons.apache.org>
Received-SPF: pass (nike.apache.org: local policy)
From: Gary Gregory <GGregory@seagullsoftware.com>
To: "dev@commons.apache.org" <dev@commons.apache.org>,
	"commits@commons.apache.org" <commits@commons.apache.org>
Date: Wed, 6 Feb 2008 14:34:26 -0500
Subject: RE: svn commit: r619115 -
 /commons/proper/lang/trunk/src/java/org/apache/commons/lang/StringUtils.java
Thread-Topic: svn commit: r619115 -
 /commons/proper/lang/trunk/src/java/org/apache/commons/lang/StringUtils.java
Thread-Index: Acho9lW93ZLUesjxRRqboTiPW1PgwAAANRwg
Message-ID: 
 <94C476C03BFF5E42AC3518FDAC9643C43C7D7F2A68@HQMAIL.rocketsoftware.com>
References: <20080206192711.9B3FC1A983E@eris.apache.org>
In-Reply-To: <20080206192711.9B3FC1A983E@eris.apache.org>
Accept-Language: en-US
Content-Language: en-US
acceptlanguage: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0

What I meant to say in the commit comment was:
Eat own dog food: Use EMPTY instead of "".

Gary

> -----Original Message-----
> From: ggregory@apache.org [mailto:ggregory@apache.org]
> Sent: Wednesday, February 06, 2008 11:27 AM
> To: commits@commons.apache.org
> Subject: svn commit: r619115 -
> /commons/proper/lang/trunk/src/java/org/apache/commons/lang/StringUtils.j=
a
> va
>
> Author: ggregory
> Date: Wed Feb  6 11:27:10 2008
> New Revision: 619115
>
> URL: http://svn.apache.org/viewvc?rev=3D619115&view=3Drev
> Log:
> Eat own dog food:
>
> Modified:
>
> commons/proper/lang/trunk/src/java/org/apache/commons/lang/StringUtils.ja=
v
> a
>
> Modified:
> commons/proper/lang/trunk/src/java/org/apache/commons/lang/StringUtils.ja=
v
> a
> URL:
> http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/java/org/apach
> e/commons/lang/StringUtils.java?rev=3D619115&r1=3D619114&r2=3D619115&view=
=3Ddiff
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> =3D=3D=3D=3D=3D=3D=3D=3D
> ---
> commons/proper/lang/trunk/src/java/org/apache/commons/lang/StringUtils.ja=
v
> a (original)
> +++
> commons/proper/lang/trunk/src/java/org/apache/commons/lang/StringUtils.ja=
v
> a Wed Feb  6 11:27:10 2008
> @@ -2351,7 +2351,7 @@
>              return ArrayUtils.EMPTY_STRING_ARRAY;
>          }
>
> -        if ( ( separator =3D=3D null ) || ( "".equals( separator ) ) ) {
> +        if ( ( separator =3D=3D null ) || ( EMPTY.equals( separator ) ) =
) {
>              // Split on whitespace.
>              return splitWorker( str, null, max, preserveAllTokens ) ;
>          }
> @@ -2391,7 +2391,7 @@
>                              end =3D len ;
>                              substrings.add( str.substring( beg ) ) ;
>                          } else {
> -                            substrings.add( "" );
> +                            substrings.add( EMPTY );
>                          }
>                      }
>                      beg =3D end + separatorLength ;
> @@ -3377,7 +3377,7 @@
>          if (isEmpty(str) || isEmpty(remove)) {
>              return str;
>          }
> -        return replace(str, remove, "", -1);
> +        return replace(str, remove, EMPTY, -1);
>      }
>
>      /**
> @@ -3856,7 +3856,7 @@
>              return str;
>          }
>          if (replaceChars =3D=3D null) {
> -            replaceChars =3D "";
> +            replaceChars =3D EMPTY;
>          }
>          boolean modified =3D false;
>          int replaceCharsLength =3D replaceChars.length();
>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org