Return-Path: Delivered-To: apmail-commons-dev-archive@www.apache.org Received: (qmail 13593 invoked from network); 12 Feb 2008 06:01:52 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 12 Feb 2008 06:01:52 -0000 Received: (qmail 55703 invoked by uid 500); 12 Feb 2008 06:01:45 -0000 Delivered-To: apmail-commons-dev-archive@commons.apache.org Received: (qmail 55201 invoked by uid 500); 12 Feb 2008 06:01:44 -0000 Mailing-List: contact dev-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Jakarta Commons Developers List" Delivered-To: mailing list dev@commons.apache.org Received: (qmail 55186 invoked by uid 99); 12 Feb 2008 06:01:44 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 11 Feb 2008 22:01:44 -0800 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of phil.steitz@gmail.com designates 66.249.82.234 as permitted sender) Received: from [66.249.82.234] (HELO wx-out-0506.google.com) (66.249.82.234) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 12 Feb 2008 06:01:13 +0000 Received: by wx-out-0506.google.com with SMTP id h29so4386740wxd.27 for ; Mon, 11 Feb 2008 22:01:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; bh=N2ZbnJlRjocluDbdbBXniq3xY3IbVF3OjV80MY8Z98c=; b=fpZbPuqPTYwehpgFQ6bSkT7gdl23rb/WukKAmLfmjoxVutzBIiI95RcDz3CojLgxY6D4E4LNFSUBJKs3etYqZPp3ONTTDj2RMsbv1VL6cTIG8w5Dixr3iNFGEzAMGXsppHINwXD7QvSKSjglRH9EZj4s4PsjbZpeQ6rsnUSslUw= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=lHZ1TbbOT1Ef9PTmHSDoYHXMfxO5LP2db6Cs/DP+73JDFO1LvZvWrGZwMhIa4Z6FJJfdzxyd2F3kpKy86fXz+qZSzrIYAO6cxYgYeE4QQOjf4lFvtHgXY7RfaooD5ABCTXMlBPOw37MevbAeGSNbmLIsuRC3eRPN6RHkToY8PwI= Received: by 10.142.240.9 with SMTP id n9mr712146wfh.79.1202796080281; Mon, 11 Feb 2008 22:01:20 -0800 (PST) Received: by 10.142.153.4 with HTTP; Mon, 11 Feb 2008 22:01:20 -0800 (PST) Message-ID: <8a81b4af0802112201n1fad260dj6d11367957e87f3a@mail.gmail.com> Date: Mon, 11 Feb 2008 23:01:20 -0700 From: "Phil Steitz" To: "Jakarta Commons Developers List" Subject: Re: svn commit: r620651 - /commons/proper/pool/trunk/src/java/org/apache/commons/pool/impl/GenericKeyedObjectPool.java In-Reply-To: <94C476C03BFF5E42AC3518FDAC9643C43C7E9D10DB@HQMAIL.rocketsoftware.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20080211223436.853C81A9832@eris.apache.org> <8a81b4af0802111503i79a8ea48vc99c6a274651f7e6@mail.gmail.com> <94C476C03BFF5E42AC3518FDAC9643C43C7E9D10DB@HQMAIL.rocketsoftware.com> X-Virus-Checked: Checked by ClamAV on apache.org Thanks for the explanation. I would, however, like to ask that this change be reverted and a JIRA ticket be opened to evaluate this API change. If real performance improvements can be demonstrated, we can consider either exposing this private inner class or removing it. Phil --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org For additional commands, e-mail: dev-help@commons.apache.org