Mailing-List: contact dev-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Jakarta Commons Developers List" <dev@commons.apache.org>
Received-SPF: pass (athena.apache.org: domain of niall.pemberton@gmail.com
 designates 72.14.204.230 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
        b=Mbgh/KAq8brX1KeF+YzdLRkzWATzCC+tNYbRCxJ1pF5yUvK+LVT3c7Y7tJJ6UuYC+fqyYUKzj2R0kdFZHhFySJVc/Ixzg73mii5g8Y5VhDuUHM46UYeUnDXEjP1okRqdBPN9jwTq+q3hr800OQ+gWUOVLJU4REgIldU2TrGkIYM=
Message-ID: <55afdc850802061155i270d102i3387f430bb2b95cb@mail.gmail.com>
Date: Wed, 6 Feb 2008 19:55:45 +0000
From: "Niall Pemberton" <niall.pemberton@gmail.com>
To: "Jakarta Commons Developers List" <dev@commons.apache.org>
Subject: Re: svn commit: r619115 -
 /commons/proper/lang/trunk/src/java/org/apache/commons/lang/StringUtils.java
In-Reply-To: 
 <94C476C03BFF5E42AC3518FDAC9643C43C7D7F2A68@HQMAIL.rocketsoftware.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <20080206192711.9B3FC1A983E@eris.apache.org>
	 <94C476C03BFF5E42AC3518FDAC9643C43C7D7F2A68@HQMAIL.rocketsoftware.com>

On Feb 6, 2008 7:34 PM, Gary Gregory <GGregory@seagullsoftware.com> wrote:
> What I meant to say in the commit comment was:
> Eat own dog food: Use EMPTY instead of "".

You can change log messages if you want

Niall

> Gary
>
> > -----Original Message-----
> > From: ggregory@apache.org [mailto:ggregory@apache.org]
> > Sent: Wednesday, February 06, 2008 11:27 AM
> > To: commits@commons.apache.org
> > Subject: svn commit: r619115 -
> > /commons/proper/lang/trunk/src/java/org/apache/commons/lang/StringUtils.ja
> > va
> >
> > Author: ggregory
> > Date: Wed Feb  6 11:27:10 2008
> > New Revision: 619115
> >
> > URL: http://svn.apache.org/viewvc?rev=619115&view=rev
> > Log:
> > Eat own dog food:
> >
> > Modified:
> >
> > commons/proper/lang/trunk/src/java/org/apache/commons/lang/StringUtils.jav
> > a
> >
> > Modified:
> > commons/proper/lang/trunk/src/java/org/apache/commons/lang/StringUtils.jav
> > a
>
> > URL:
> > http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/java/org/apach
> > e/commons/lang/StringUtils.java?rev=619115&r1=619114&r2=619115&view=diff
> > ======================================================================
> > ========
> > ---
> > commons/proper/lang/trunk/src/java/org/apache/commons/lang/StringUtils.jav
> > a (original)
> > +++
> > commons/proper/lang/trunk/src/java/org/apache/commons/lang/StringUtils.jav
> > a Wed Feb  6 11:27:10 2008
> > @@ -2351,7 +2351,7 @@
> >              return ArrayUtils.EMPTY_STRING_ARRAY;
> >          }
> >
> > -        if ( ( separator == null ) || ( "".equals( separator ) ) ) {
> > +        if ( ( separator == null ) || ( EMPTY.equals( separator ) ) ) {
> >              // Split on whitespace.
> >              return splitWorker( str, null, max, preserveAllTokens ) ;
> >          }
> > @@ -2391,7 +2391,7 @@
> >                              end = len ;
> >                              substrings.add( str.substring( beg ) ) ;
> >                          } else {
> > -                            substrings.add( "" );
> > +                            substrings.add( EMPTY );
> >                          }
> >                      }
> >                      beg = end + separatorLength ;
> > @@ -3377,7 +3377,7 @@
> >          if (isEmpty(str) || isEmpty(remove)) {
> >              return str;
> >          }
> > -        return replace(str, remove, "", -1);
> > +        return replace(str, remove, EMPTY, -1);
> >      }
> >
> >      /**
> > @@ -3856,7 +3856,7 @@
> >              return str;
> >          }
> >          if (replaceChars == null) {
> > -            replaceChars = "";
> > +            replaceChars = EMPTY;
> >          }
> >          boolean modified = false;
> >          int replaceCharsLength = replaceChars.length();
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org