commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gary Gregory <GGreg...@seagullsoftware.com>
Subject RE: svn commit: r620174 - /commons/proper/io/trunk/src/java/org/apache/commons/io/IOUtils.java
Date Sun, 10 Feb 2008 21:41:32 GMT
Hi All:

In short: Feel free to revert.

In detail:

Ah, sorry about the formatting, it was not my intention to commit the generics changes /plus/
the different format. It's just a habit from work: we all share the same Eclipse format template
for a given project, so I format all the time without thinking about it. If format changes
show up in our CVS/SVN emails, then the code that was there before did not follow the Eclipse
template.

The great thing is that I never manually format any code anymore. Thanks to Eclipse and all
of our code looks the same. What a waste of time this used to be: Spaces, brackets, parentheses,
tabs, Cr/Cr-Lf, etc. All of that manual formatting nonsense is gone from my daily practice.
At work, we've not even had a discussion about formatting in years.

Unfortunately, formatting is pretty random across all of the code I've seen in [commons] projects,
it can change from file to file within the same project and from method to method in the same
file. It would be great if we could share an Eclipse template or at least the rules that go
in the template as I know not everyone likes Eclipse and some folks feel that their IDE is
better, or their Notepad is better.

Gary

> -----Original Message-----
> From: Stephen Colebourne [mailto:scolebourne@btopenworld.com]
> Sent: Sunday, February 10, 2008 9:52 AM
> To: Jakarta Commons Developers List
> Subject: Re: svn commit: r620174 -
> /commons/proper/io/trunk/src/java/org/apache/commons/io/IOUtils.java
>
> Niall Pemberton wrote:
> > Its painful to have to look through 30 pages of a commit message thats
> > mostly re-formatting to find the real changes - which from what I can
> > see is four method signature changes and a bit of minor refactoring.
> > Could you please do reformatting type changes as a separate commit so
> > it makes it easier to follow along. Also in this case I don't think
> > most of the reformatting improved anything and things like splitting
> > @param statements over two lines is actually worse tor read.
>
> I think this commit should be reverted, and reapplied with just the
> relevant changes. The [io] codebase does not need extensive formatting,
> as it is already in a good style (and these changes make it worse).
>
> Stephen
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message