commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Oliver Heger <oliver.he...@oliver-heger.de>
Subject Re: svn commit: r628395 - in /commons/proper/configuration/branches/configuration2_experimental/src/main/java/org/apache/commons/configuration2: beanutils/BeanHelper.java interpol/ConfigurationInterpolator.java
Date Sun, 17 Feb 2008 20:34:40 GMT
sebb schrieb:
> On 17/02/2008, Emmanuel Bourg <ebourg@apache.org> wrote:
>> Oliver Heger a écrit :
>>> This commit contains a lot of noise related to formatting changes. This
>>> makes it very difficult to find out what you actually changed.
>>>
>>> Can you please try to minimize reformatting as much as possible?
>>>
>>> Thanks
>>> Oliver
>> Do you mind if we set the column limit to 120 characters ? 80 characters
>> is quite small with today screens and wrapped code is difficult to read.
>>
> 
> Even with a largish screen, 120 characters is quite a lot if using an
> IDE with multiple windows.
> 
> Whether wrapped code is difficult to read depends on where the code is
> wrapped ...

Ah, the old discussion about line lengths ;-)

I personally prefer shorter lengths (maybe up to 100 characters), but 
would not veto against longer lines. However I am against reformatting 
the existing code base.

Oliver

> 
>> Emmanuel Bourg
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>>
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message