commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stephen Colebourne <scolebou...@btopenworld.com>
Subject Re: svn commit: r620174 - /commons/proper/io/trunk/src/java/org/apache/commons/io/IOUtils.java
Date Sun, 10 Feb 2008 17:52:26 GMT
Niall Pemberton wrote:
> Its painful to have to look through 30 pages of a commit message thats
> mostly re-formatting to find the real changes - which from what I can
> see is four method signature changes and a bit of minor refactoring.
> Could you please do reformatting type changes as a separate commit so
> it makes it easier to follow along. Also in this case I don't think
> most of the reformatting improved anything and things like splitting
> @param statements over two lines is actually worse tor read.

I think this commit should be reverted, and reapplied with just the 
relevant changes. The [io] codebase does not need extensive formatting, 
as it is already in a good style (and these changes make it worse).

Stephen

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message