commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Niall Pemberton" <niall.pember...@gmail.com>
Subject Re: [VOTE] Release Commons IO 1.4 based on RC3
Date Thu, 17 Jan 2008 16:32:40 GMT
On Jan 17, 2008 4:09 PM, sebb <sebbaz@gmail.com> wrote:
> On 17/01/2008, Niall Pemberton <niall.pemberton@gmail.com> wrote:
> > The changes since RC2 are:
> >
> >  - Separate out tests requiring JDK 1.4 and change ant build to run
> > tests depending on JDK version
>
> There's a problem with the Ant tests - Maven2 runs 470 tests, whereas
> Ant only runs 461, so 9 tests are missing.
>
> After a lot of debugging, it appears that FileCleaningTrackerTestCase
> is not being run by Ant.
>
> This is because the class is not in any of the Package test classes.
>
> Possible fixes:
> - add FileCleaningTrackerTestCase to
> org.apache.commons.io.PackageTestSuite (or to the 1.3 test Ant target)
> - use includes/excludes with <junit> <batchtest>.
>
> The first option is less work initially, but is harder to maintain, as
> it is easy to forget to update the Package test classes (this has
> already happened).
>
> The second option means that new test cases will automatically be picked up.
>
> I have attached a build.xml patch which use <junit> <batchtest> to
> process the tests. The output now looks similar to the Maven test
> output. I've checked that the Java 1.4 ant test now runs the same
> number of tests as Maven.

OK thanks for spotting this, but since m2 is the primary build system
on this release and it runs all the tests then this is a minor,
non-showstopping issue though right?

Niall

> >  - Correct m1 and ant builds to use the same "target" option as the m2 build
> >
> > The artifacts are here:
> > http://people.apache.org/~niallp/io-1.4-RC3/
> >
> > SVN Tag:
> > http://svn.apache.org/viewvc/commons/proper/io/tags/commons-io-1.4-RC3/
> >
> > Site:
> > http://people.apache.org/~niallp/io-1.4-RC3/site/
> > (note m2 generates relative links, so some don't work - but the site
> > is for info and not included in the release artifacts)
> >
> > Release Notes:
> > http://people.apache.org/~niallp/io-1.4-RC3/site/upgradeto1_4.html
> > (These are a copy of RELEASE-NOTES.txt in html form)
> >
> > RAT Report:
> > http://people.apache.org/~niallp/io-1.4-RC3/site/rat-report.html
> >
> > CLIRR Report:
> > http://people.apache.org/~niallp/io-1.4-RC3/site/clirr-report.html
> >
> > RC3 has been built with m2 - but m1 and ant builds are available - details here:
> > http://people.apache.org/~niallp/io-1.4-RC3/site/building.html
> >
> > Vote is open for 72 hours
> >
> > Thanks in advance for your feedback/votes.
> >
> > Niall
> > ------------------------------------------------------------------------------------------------------------->
> >
> > [  ] +1  I support this release
> > [  ] +0  I am OK with this release
> > [  ] -0   OK, but....
> > [  ] -1   I do not support this release
> >

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message