commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Niall Pemberton" <niall.pember...@gmail.com>
Subject Re: [pool] 1.4-RC2 available for review
Date Fri, 11 Jan 2008 15:44:14 GMT
On Jan 11, 2008 3:35 PM, Phil Steitz <phil.steitz@gmail.com> wrote:
> On 1/11/08, Niall Pemberton <niall.pemberton@gmail.com> wrote:
> > On Jan 7, 2008 5:10 AM, Phil Steitz <phil.steitz@gmail.com> wrote:
> > > I have tagged and rolled another (hopefully last) RC for pool-1.4.  If
> > > there are no significant problems reported with this RC, I will roll a
> > > final distribution making only version number changes and kick off a
> > > VOTE based on the release bits later this week.
> >
> > Looks good to me tests run OK, distros look OK. I ran the RAT report
> > against the source distro:
> >
> > http://people.apache.org/~niallp/rat-commons-pool-1.4-RC2-src.txt
> >
> > I also ran CLIRR on the 1_4_RELEASE_BRANCH and that looks good too
> > (nothing > "info" in the severity.
> >
> > The only two comments are that would be nice IMO if the m2 pom was
> > included (for users who want might want to use it) and seems strange
> > to include the jar in the source distro.
>
> Good catch.  Will fix the missing POM.  Having the jar in the source
> distro is I think an m1 thing.
> >
> > Lastly do you mind me adding OSGi entries to the jar's manifest (I can
> > do this for both m1 and m2) - or is it too late and you're going to
> > call a vote based on RC2?
> >
> Thanks, Niall.  You caught me just in time.  I was just about to copy
> the final tag.  If you add the OSGi stuff to 1_4_RELEASE_BRANCH in the
> next 10 hrs or so, I will get it in to the final that I am planning to
> roll this evening.

Great thanks, I had them ready to go on th off-chance you were happy to accept:

http://svn.apache.org/viewvc?view=rev&revision=611207

Niall

> Thanks for reviewing.
>
> Phil
>
> > Niall
> >
> > > Changes since RC1:
> > >
> > > * Site fixes
> > > * Javadoc fixes
> > > * Improved formatting of release notes
> > > * Modernize Ant build (POOL-118)
> > > * Made eviction thread a daemon
> > > * Made addObject synchronized (as in 1.3) POOL-120
> > > (I chose the simple fix for this issue, see comments in POOL-120)
> > >
> > > The tars/zips are here:
> > > http://people.apache.org/~psteitz/pool-1.4-RC2/distributions
> > >
> > > Site:
> > > http://people.apache.org/~psteitz/pool-1.4-RC2/docs/
> > >
> > > Release Notes:
> > > http://people.apache.org/~psteitz/pool-1.4-RC2/RELEASE-NOTES.txt
> > >
> > > To faciliated testing, I have (manually) uploaded the RC jar to the
> > > apache m1 snapshot repo:
> > > http://people.apache.org/repo/m1-snapshot-repository/commons-pool/
> > >
> > > Thanks in advance for your feedback.  Patches / direct fixes should be
> > > against branches/1_4_RELEASE_BRANCH.  The RC was built from
> > > tags/POOL_1_4_RC2.
> >
>
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> > For additional commands, e-mail: dev-help@commons.apache.org
> >
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message