commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Oliver Heger <oliver.he...@oliver-heger.de>
Subject Re: [VOTE] Release pool 1.4
Date Mon, 14 Jan 2008 21:13:22 GMT
The artifacts look good, the build also succeeded in all variants (on a 
JDK 1.6). So I am +1 for this release.

Two minor points:
- On my first attempt to build with maven 2 I got the test failure 
below. However this was not reproducable, further builds succeeded. Has 
anybody else seen this?

- In the manifest of the jar (in the binary distribution) the headers 
for Import- and Export-Package look a bit strange. There seems to be a 
hard line break in the package name. I am no OSGi expert. Is this okay?

Oliver

-------------------------------------------------------------------------------
Test set: org.apache.commons.pool.impl.TestGenericKeyedObjectPool
-------------------------------------------------------------------------------
Tests run: 38, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 22.275 
sec <<< FAILURE!
testEviction2(org.apache.commons.pool.impl.TestGenericKeyedObjectPool) 
Time elapsed: 1.03 sec  <<< FAILURE!
junit.framework.AssertionFailedError: Should be less than 1000 idle, 
found 1000
	at junit.framework.Assert.fail(Assert.java:47)
	at junit.framework.Assert.assertTrue(Assert.java:20)
	at 
org.apache.commons.pool.impl.TestGenericKeyedObjectPool.testEviction2(TestGenericKeyedObjectPool.java:442)
	at 
org.apache.commons.pool.impl.TestGenericKeyedObjectPool.testEviction2(TestGenericKeyedObjectPool.java:442)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
	at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
	at java.lang.reflect.Method.invoke(Method.java:597)
	at junit.framework.TestCase.runTest(TestCase.java:164)
	at junit.framework.TestCase.runBare(TestCase.java:130)
	at junit.framework.TestResult$1.protect(TestResult.java:106)
	at junit.framework.TestResult.runProtected(TestResult.java:124)
	at junit.framework.TestResult.run(TestResult.java:109)
	at junit.framework.TestCase.run(TestCase.java:120)
	at junit.framework.TestSuite.runTest(TestSuite.java:230)
	at junit.framework.TestSuite.run(TestSuite.java:225)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
	at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
	at java.lang.reflect.Method.invoke(Method.java:597)
	at 
org.apache.maven.surefire.junit.JUnitTestSet.execute(JUnitTestSet.java:213)
	at 
org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.executeTestSet(AbstractDirectoryTestSuite.java:138)
	at 
org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.execute(AbstractDirectoryTestSuite.java:125)
	at org.apache.maven.surefire.Surefire.run(Surefire.java:132)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
	at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
	at java.lang.reflect.Method.invoke(Method.java:597)
	at 
org.apache.maven.surefire.booter.SurefireBooter.runSuitesInProcess(SurefireBooter.java:290)
	at 
org.apache.maven.surefire.booter.SurefireBooter.main(SurefireBooter.java:818)



Phil Steitz schrieb:
> This is a vote to release commons pool 1.4.
> 
> The signed source distributions (what we are voting on) are here:
> http://people.apache.org/~psteitz/pool-1.4-RC3/distributions/commons-pool-1.4-src.tar.gz
> http://people.apache.org/~psteitz/pool-1.4-RC3/distributions/commons-pool-1.4-src.zip
> 
> Site:
> http://people.apache.org/~psteitz/pool-1.4-RC3/docs/
> 
> Release Notes:
> http://people.apache.org/~psteitz/pool-1.4-RC2/RELEASE-NOTES.txt
> 
> Changes since RC2:
> * Removed jar from source distribution
> * Added OSGi manifest entries
> * Added m2 pom.xml to source distribution
> 
> Thanks in advance for your VOTES.
> This VOTE will remain open for 72 hours, closing at 2008-JAN-15 23:30 GMT.
> 
> Phil
> ------------------------------------------------------------------------------------------------------------->
> 
> [  ] +1  I support this release
> [  ] +0  I am OK with this release
> [  ] -0   OK, but....
> [  ] -1   I do not support this release
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message