commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Luc Maisonobe <Luc.Maison...@free.fr>
Subject [math] possible issue with ValueServer.getNextReplay()
Date Sun, 13 Jan 2008 20:16:32 GMT
Still playing with findbugs, I have encounter another thing I don't 
understand.

The getNextReplay() method in ValueServer has a wrap feature to restart 
file reading when EOF is encountered. This feature is triggered when 
readLine returns null, but only one test is performed.

I think that this  could produce a NullPointerException is the provided 
file is empty. I don't see any check for this. Adding a check would 
imply changing the method signature by adding a new Exception (the 
method only declares throwing IOException).

Any thoughts about this ?

Lyc


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message