commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject Re: [VOTE] Release commons-fileupload 1.2.1 (rc3)
Date Thu, 10 Jan 2008 15:41:52 GMT
On 10/01/2008, Jochen Wiedmann <jochen.wiedmann@gmail.com> wrote:
> I forgot to note: The distribution is available on
>
>    http://people.apache.org/~jochen/commons-fileupload/dist

-1:
The NOTICE files in the jars are non-standard. They also refer to
Commons-IO which is not part of the jar. The NOTICE file is *only* for
items that are included in the distribution, not external
dependencies.

The NOTICE.txt files in the archives are OK; the same files should be
in the jars.

-0: MD5 and SHA1 files should have "space *" - not just a single space
- between the hash and the filename. This should be fixed if there are
any other reasons to recreate them.

> The proposed site is at
>
>    http://people.apache.org/~jochen/commons-fileupload/site

Cannot find any reference to which versions of Java are supported.

What does "(optional)" mean in the Dependencies section under Commons IO?

Javadoc footer looks wrong:

Copyright Â(c)

Not sure what the A-circumflex character is doing there.
Should probably use &copy; instead of actual characters if possible
(as is done in the cross-reference)

I assume that the SVN tag is:

http://svn.apache.org/viewvc/commons/proper/fileupload/tags/commons-fileupload-1.2.1rc3/

> Sorry,
>
> Jochen
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message