Mailing-List: contact dev-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Jakarta Commons Developers List" <dev@commons.apache.org>
Received-SPF: pass (athena.apache.org: domain of phil.steitz@gmail.com
 designates 64.233.182.184 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
        b=YSjK9dtixZSMiYNDsG+fZ/lBsB5QrZZtsQ3ZUlrDqcjAt+/3kq8Wz4mq4+MEpVXXn5E4MIMj6cG3GpW3bQQ41BIvnOst5et+xSlr1AP/4lv29bujgTMF6HSFw56JwAs/f6gWGkkjw/vr5GDE+SobJhCnTsWB6/6i66ilP934BI0=
Message-ID: <8a81b4af0712091935j13a44e71q651d76c74ba8e077@mail.gmail.com>
Date: Sun, 9 Dec 2007 20:35:28 -0700
From: "Phil Steitz" <phil.steitz@gmail.com>
To: "Jakarta Commons Developers List" <dev@commons.apache.org>
Subject: Re: [POOL] Offer of help for a 1.4 release
In-Reply-To: <475C7E6F.6040401@apache.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <4752F4C5.6020403@apache.org>
	 <8a81b4af0712021144mff335e6of6aa465de6ca5e62@mail.gmail.com>
	 <47545EA7.7020201@apache.org> <475C7E6F.6040401@apache.org>

On Dec 9, 2007 4:46 PM, Mark Thomas <markt@apache.org> wrote:
> Mark Thomas wrote:
> > Phil Steitz wrote:
> >> On Dec 2, 2007 11:09 AM, Mark Thomas <markt@apache.org> wrote:
> >>> Hi,
> >>>
> >>> Tomcat has been bitten [1] by a bug [2] in pool-1.3. Currently we are
> >>> considering reverting to pool-1.2 but would obviously prefer to move to
> >>> pool-1.4 (that included a fix for [2]) due to the many fixes in 1.3.
> >>>
> >>> A quick scan of the archives suggests that an offer of an extra pair of
> >>> hands might help speed up a pool-1.4 release in the near term. So, here I am.
> >> Thanks!  This is exactly what is needed.
> >
> > OK. I have trunk checked out and building. I'll starting looking at
> > POOL-86, POOL-97, POOL-93 & POOL-108 in terms of reviewing what is there
> > and developing patches where there are gaps. I'll need to get my head
> > around the pool code so I might be quiet for a couple of days.
> >
> > I'll add JIRA comments when I have something useful to say.
>
> I have taken a look at each of the issues above. Comments added to JIRA. In
> summary:

Thanks!

> POOL-86  - The patch in JIRA looks good to me
To be clear, are you referring to the patch that was applied in
rr582538. - i.e., the code in trunk?  (thanks, btw, for completing
some cleanup missed there :)

> POOL-93  - Proposed improved patch based on patches in JIRA
Committed.

> POOL-97  - Proposed alternative patch that fixes 97 without a regression

Committed.

> POOL-108 - Proposed improved patch (see POOL-93) based on patch in JIRA
>
> I'm happy to re-work any/all of the patches if required.

Only rework required will be if we decide to roll back or modify the
POOL-86 change.

Thanks again for your help on this.

Phil

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org