commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject Re: svn commit: r604085 - /commons/proper/pool/trunk/src/java/org/apache/commons/pool/impl/GenericObjectPool.java
Date Sat, 15 Dec 2007 14:28:54 GMT
On 15/12/2007, Phil Steitz <phil.steitz@gmail.com> wrote:
> On Dec 14, 2007 7:07 AM, sebb <sebbaz@gmail.com> wrote:
> >
> > On 14/12/2007, psteitz@apache.org <psteitz@apache.org> wrote:
> > > Author: psteitz
> > > Date: Thu Dec 13 18:00:35 2007
> > > New Revision: 604085
> > >
> > > URL: http://svn.apache.org/viewvc?rev=604085&view=rev
> > > Log:
> > > Javadoc fixes.
> > >
> > > Modified:
> > >    commons/proper/pool/trunk/src/java/org/apache/commons/pool/impl/GenericObjectPool.java
> > >
> > > Modified: commons/proper/pool/trunk/src/java/org/apache/commons/pool/impl/GenericObjectPool.java
> > > URL: http://svn.apache.org/viewvc/commons/proper/pool/trunk/src/java/org/apache/commons/pool/impl/GenericObjectPool.java?rev=604085&r1=604084&r2=604085&view=diff
> > > ==============================================================================
> > > --- commons/proper/pool/trunk/src/java/org/apache/commons/pool/impl/GenericObjectPool.java
(original)
> > > +++ commons/proper/pool/trunk/src/java/org/apache/commons/pool/impl/GenericObjectPool.java
Thu Dec 13 18:00:35 2007
> > > @@ -122,6 +122,19 @@
> > >  *  </li>
> > >  * </ul>
> > >  * <p>
> > > + * <p>
> > > + * The pool can be configured to behave as a LIFO queue with respect to idle
> > > + * objects - always returning the most recently used object from the pool,
> > > + * or as a FIFO queue, where borrowObject always returns the oldest object
> > > + * in the idle object pool.
> > > + * <ul>
> > > + *  <li>
> > > + *   {@link #setLifo <i>Lifo</i>}
> >
> > That should probably be #setLifo(boolean) ?
>
> Hmm.  Here and elselwere I was following the style of the the
> surrounding code.  The javadoc tool fills in the missing argument,
> since it is unambiguous in this case.

Sorry, you're right.

I was extrapolating from other #method links - such as {@link
Object#wait} at line 67 which is ambiguous - and assumed (without
checking) that all unqualified names should be qualified. My bad.


> Phil
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message