commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject Re: [pool] 1.3-1.4 compatibility
Date Wed, 12 Dec 2007 20:12:53 GMT
On 12/12/2007, sebb <sebbaz@gmail.com> wrote:
> On 12/12/2007, Phil Steitz <phil.steitz@gmail.com> wrote:
> > Quick update on this.
> >
> > I created 1_4_RELEASE_BRANCH so we should be reviewing / patching the
> > code there for the release.
> >
> > Clirr flagged only the change in default values for
> > DEFAULT_TEST_ON_BORROW mentioned above.  Among the changes described
> > in [1] that have been implemented, I think we need to roll back
> >
> > 0) change in DEFAULT_TEST_ON_BORROW values
> >
> > 1) the behavior change that forgoes validation prior to returning
> > newly created objects from the pool (see the diffs for e.g. GOP
> > rr385746)
> >
> > 2) the change to have [Keyed]PoolableObjectFactory getNumIdle and
> > getNumActive methods
> > return negative values if they aren't supported.
> >
> > I don't think the other changes, which improve robustness and
> > documentation, need to be rolled back or deferred to a 2.0.
> >
> > I will make the changes in 0)-2) in the 1.4 release branch and add
> > details on the other behavior changes to the release notes.
> >
> > I will cut the RC using maven 1 and generate release notes from
> > changes.xml.  Patches on this and other site elements most welcome.
> > Also more eyeballs on the changes recently made and the changelog for
> > the core classes would be appreciated.
>
> There are a few Javadoc warnings, e.g. @see Object#wait should be @see
> Object#wait(). I'll add a patch to JIRA shortly in case you want to
> fix those.

Also added JIRA patch to add Java source and target to manifest used
by build.xml.

By the way, build.xml creates the build/ directory tree, but this is
not excluded from SVN, unlike dist/ and target/. Not sure how to
create an SVN property patch...

Also project.xml still refers to junit3.8.1, whereas pom says 3.8.2.

> > Thanks!
> >
> > Phil
> >
> > [1] http://www.nabble.com/-pool--roadmap-to1431371.html#a1435963
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> > For additional commands, e-mail: dev-help@commons.apache.org
> >
> >
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message