Mailing-List: contact dev-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Jakarta Commons Developers List" <dev@commons.apache.org>
Received-SPF: pass (nike.apache.org: local policy)
Content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: multipart/alternative;
	boundary="----_=_NextPart_001_01C82AF3.1461F2BE"
Subject: "Already closed." exception in
 org.apache.commons.dbcp.PoolableConnection
Date: Mon, 19 Nov 2007 16:28:08 -0500
Message-ID: <D776BFE047B6314DB21CD0C15EA4D12C23DF85@CATL0MS02.corp.cox.com>
Thread-Topic: "Already closed." exception in
 org.apache.commons.dbcp.PoolableConnection
Thread-Index: Acgq8xQN+nrjzxUESAW6sf/FBlMupA==
From: <Jeffrey.Constantin@cox.com>
To: <dev@commons.apache.org>

------_=_NextPart_001_01C82AF3.1461F2BE
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

To Whom It May Concern:
=20
Why is it necessary to throw a new SQLException("Already closed") when
the purpose of the close() method is to close the connection. Seems to
me this Exception is not necessary.
=20
In my code (Tomcat/DBCP/iBATIS) apparently iBATIS is trying to close an
already closed connection( without checking ) and this causes the
close() method to throw the exception.
=20
Any design thoughts are greatly appreciated.
=20
Thanks,
=20
Jeff
=20
    /**
     * Returns me to my pool.
     */
     public synchronized void close() throws SQLException {
        boolean isClosed =3D false;
        try {
            isClosed =3D isClosed();
        } catch (SQLException e) {
            try {
                _pool.invalidateObject(this); // XXX should be guarded
to happen at most once
            } catch (Exception ie) {
                // DO NOTHING the original exception will be rethrown
            }
            throw new SQLNestedException("Cannot close connection
(isClosed check failed)", e);
        }
        if (isClosed) {
            try {
                _pool.invalidateObject(this); // XXX should be guarded
to happen at most once
            } catch (Exception ie) {
                // DO NOTHING, "Already closed" exception thrown below
            }
            throw new SQLException("Already closed.");
        } else {
            try {
                _pool.returnObject(this); // XXX should be guarded to
happen at most once
            } catch(SQLException e) {
                throw e;
            } catch(RuntimeException e) {
                throw e;
            } catch(Exception e) {
                throw new SQLNestedException("Cannot close connection
(return to pool failed)", e);
            }
        }
    }

=20

------_=_NextPart_001_01C82AF3.1461F2BE--