commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dennis Lundberg <denn...@apache.org>
Subject Re: svn commit: r595723 - in /commons/proper/commons-skin/trunk: pom.xml src/main/resources/css/site.css
Date Mon, 19 Nov 2007 22:31:38 GMT
Three things:

1. Why change the versioning scheme for the skin? ( 1.1-SNAP -> 2-SNAP ) 
Do you feel that it is more like a parent pom than a component? The 
skins that are maintained by the Maven project use x.y.x versions.

2. Did you mean to remove the license from site.css?

3. Would you mind deploying a SNAPSHOT of the new version of the skin so 
that people can use without having to build it.

Thanks

niallp@apache.org wrote:
> Author: niallp
> Date: Fri Nov 16 08:22:19 2007
> New Revision: 595723
> 
> URL: http://svn.apache.org/viewvc?rev=595723&view=rev
> Log:
> Change skin sit.css to import http://commons.apache.org/style/commons-maven.css
> 
> Modified:
>     commons/proper/commons-skin/trunk/pom.xml
>     commons/proper/commons-skin/trunk/src/main/resources/css/site.css
> 
> Modified: commons/proper/commons-skin/trunk/pom.xml
> URL: http://svn.apache.org/viewvc/commons/proper/commons-skin/trunk/pom.xml?rev=595723&r1=595722&r2=595723&view=diff
> ==============================================================================
> --- commons/proper/commons-skin/trunk/pom.xml (original)
> +++ commons/proper/commons-skin/trunk/pom.xml Fri Nov 16 08:22:19 2007
> @@ -20,10 +20,10 @@
>    <parent>
>      <groupId>org.apache.commons</groupId>
>      <artifactId>commons-parent</artifactId>
> -    <version>1</version>
> +    <version>5</version>
>    </parent>
>    <artifactId>commons-skin</artifactId>
> -  <version>1.1-SNAPSHOT</version>
> +  <version>2-SNAPSHOT</version>
>    <name>Commons Skin</name>
>    <description>Commons Skin</description>
>    <scm>
> 
> Modified: commons/proper/commons-skin/trunk/src/main/resources/css/site.css
> URL: http://svn.apache.org/viewvc/commons/proper/commons-skin/trunk/src/main/resources/css/site.css?rev=595723&r1=595722&r2=595723&view=diff
> ==============================================================================
> --- commons/proper/commons-skin/trunk/src/main/resources/css/site.css (original)
> +++ commons/proper/commons-skin/trunk/src/main/resources/css/site.css Fri Nov 16 08:22:19
2007
> @@ -1,16 +1 @@
> -/*
> -Licensed to the Apache Software Foundation (ASF) under one
> -or more contributor license agreements.  See the NOTICE file
> -distributed with this work for additional information
> -regarding copyright ownership.  The ASF licenses this file
> -to you under the Apache License, Version 2.0 (the
> -"License"); you may not use this file except in compliance
> -with the License.  You may obtain a copy of the License at
> -  http://www.apache.org/licenses/LICENSE-2.0
> -Unless required by applicable law or agreed to in writing,
> -software distributed under the License is distributed on an
> -"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
> -KIND, either express or implied.  See the License for the
> -specific language governing permissions and limitations
> -under the License.
> -*/
> +@import url("http://commons.apache.org/style/commons-maven.css");
> 
> 
> 


-- 
Dennis Lundberg

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message