commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject Re: svn commit: r596370 - /commons/proper/commons-parent/trunk/pom.xml
Date Mon, 19 Nov 2007 18:43:15 GMT
On 19/11/2007, Dennis Lundberg <dennisl@apache.org> wrote:
> sebb wrote:
> > On 19/11/2007, Dennis Lundberg <dennisl@apache.org> wrote:
> >> sebb wrote:
> >>> On 19/11/2007, dennisl@apache.org <dennisl@apache.org> wrote:
> >>>> Author: dennisl
> >>>> Date: Mon Nov 19 09:10:07 2007
> >>>> New Revision: 596370
> >>>>
> >>>> URL: http://svn.apache.org/viewvc?rev=596370&view=rev
> >>>> Log:
> >>>> Use the correct value for the X-Compile-Target-JDK manifestEntry.
> >>>>
> >>>> Modified:
> >>>>    commons/proper/commons-parent/trunk/pom.xml
> >>>>
> >>>> Modified: commons/proper/commons-parent/trunk/pom.xml
> >>>> URL: http://svn.apache.org/viewvc/commons/proper/commons-parent/trunk/pom.xml?rev=596370&r1=596369&r2=596370&view=diff
> >>>> ==============================================================================
> >>>> --- commons/proper/commons-parent/trunk/pom.xml (original)
> >>>> +++ commons/proper/commons-parent/trunk/pom.xml Mon Nov 19 09:10:07
2007
> >>>> @@ -172,7 +172,7 @@
> >>>>               <Implementation-Vendor>${project.organization.name}</Implementation-Vendor>
> >>>>               <Implementation-Vendor-Id>org.apache</Implementation-Vendor-Id>
> >>>>               <X-Compile-Source-JDK>${maven.compile.source}</X-Compile-Source-JDK>
> >>>> -              <X-Compile-Target-JDK>${maven.compile.source}</X-Compile-Target-JDK>
> >>>> +              <X-Compile-Target-JDK>${maven.compile.target}</X-Compile-Target-JDK>
> >>> Have any formal releases been affected by this bug?
> >> These components have been released with Maven 2 (according to the
> >> Apache repo):
> >> - commons-email 1.1
> >> - commons-fileupload 1.2
> >> - commons-io 1.3.2
> >> - commons-jci 1.0
> >>
> >> All of them seems to have compile.target == compile.source
> >
> > That's lucky...
>
> Indeed.
>
> > I notice that you patched the logging pom to work-round this error;
> > this suggests that the updated parent pom is not automatically used by
> > projects.
>
> Exactly, that is because we want reproducible builds. No matter how
> wrong we were when we created commons-foo-1.0, we want to be able to
> recreate exactly that release, at any given point in time.
>
> > If so, then future releases could presumably still be affected by the
> > parent pom bug?
>
> Yes, unless they update their pom to use a parent that has this fix in
> it. That will be commons-parent-6, when that has been released.
>
> > BTW, how can one tell which version of the parent pom has been used to
> > build a project?
>
> It is defined in the pom.xml file for the project. Near the top you will
> find a <parent> element that defines the parent pom. For Commons the
> current parent is org.apache.commons:commons-parent:5.

OK, thanks, that makes sense now.

> >>> I.e. where compile.target != source.target
> >>>
> >>> If so, what should be done?
> >>>
> >>>>             </manifestEntries>
> >>>>           </archive>
> >>>>         </configuration>
> >>>>
> >>>>
> >>>>
> >>> ---------------------------------------------------------------------
> >>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> >>> For additional commands, e-mail: dev-help@commons.apache.org
> >>>
> >>>
> >>
> >> --
> >> Dennis Lundberg
> >>
>
>
>
> --
> Dennis Lundberg
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message