Mailing-List: contact dev-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Jakarta Commons Developers List" <dev@commons.apache.org>
Received-SPF: neutral (athena.apache.org: local policy)
DomainKey-Signature: a=rsa-sha1; s=serpent; d=yahoo-inc.com; c=nofws; q=dns;
	h=from:to:subject:date:message-id:mime-version:content-type:
	x-mailer:x-mimeole:thread-index;
	b=KyqysfC1qcYtMPg5GZNE8slF+4rYc7BSsCb5U64uSQC1CVlr4Z7bE3w2ql3Lqwms
From: "Bhaskar" <bhaskar@yahoo-inc.com>
To: <dev@commons.apache.org>
Subject: Enhancement/suggession - GenericObjectPool.evict - log a warning if
 _numActive goes below _minIdle
Date: Mon, 15 Oct 2007 12:41:50 +0530
Message-ID: <00ca01c80efa$ab19b260$9c48420a@ds.corp.yahoo.com>
MIME-Version: 1.0
Content-Type: multipart/alternative;
	boundary="----=_NextPart_000_00CB_01C80F28.C4D1EE60"
Thread-Index: AcgO+qhQ8NUy37CeSHOyuFjUMkHprQ==

------=_NextPart_000_00CB_01C80F28.C4D1EE60
Content-Type: text/plain;
	charset="US-ASCII"
Content-Transfer-Encoding: 7bit

Hi,
Recently we had a hardware issue due to which numActive use to drop
drastically (in netstat I found that number of connections established to
oracle db was keep on reducing). 
 
Enhancement/Suggession is to log a warning or recreate a new connection and
put into pool when _numActive  < _minIdle or _numActive < _maxIdle (please
refer to the suggested  code change)
 
I am new to this community so, i might be wrong in the code which i am
refering to.
 
Please let me know if it make sence to submit the patch on this.
 
thanks in advance,
Bhaskar
Suggested code change: 

public class GenericObjectPool extends BaseObjectPool implements ObjectPool
{

   .............

   ..............

    public synchronized void evict() throws Exception {

           .........

           .........

          if(removeObject) {

                     try {

                            iter.remove();

                            int prevNumActive = _numActive;

                           _factory.destroyObject(pair.value);

                           //suggession start

                            if( (prevNumActive < _maxIdle) || (_numActive <
_numIdle) )  {

                                       //log a warning telling that too many
connections are getting invalidated during eviction time.

                                               or

                                       //create a new connection and put it
into pool back.

                           }

                           //suggession end                 

                            } catch(Exception e) {

                                       // ignored

                            } 

}

PS: 

Enviornment: RHEL 4 with JDK 1.4

Configs: 

maxActive = 50

maxIdle = 30

factory=org.apache.commons.dbcp.BasicDataSourceFactory

maxWait=10000

timeBetweenEvictionRunsMillis=900000

numTestsPerEvictionRun=50

minEvictableIdleTimeMillis=1800000

testWhileIdle=true

I noticed that in netstat, number of connections with oracle db got reduced
from 12 to 8 at some point of time. 


------=_NextPart_000_00CB_01C80F28.C4D1EE60--