commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Phil Steitz" <phil.ste...@gmail.com>
Subject Re: [Math] rolling calculations with lag
Date Fri, 12 Oct 2007 20:28:11 GMT
Thanks!

Had a quick look and have a couple of comments.

First, have a look at the developers guide (linked on the [math]
website) for style and other guidlines and if you are not set up yet
with maven, let me know if you  need help getting set up so you can
get checkstyle and pmd reports.

We should probably talk a little about the API - i.e., what the method
names actually mean - and this all needs to be specified in the method
javadoc.  Commons math is as much about the API as the
implementations, so we try to be pretty careful about getting the
names and semantics right.  Like other commons components, we have an
implicit commitment to maintain backward compatibility, so that makes
it even more important to get the APIs right.  So can you describe
what exactly the public methods mean and why they are named as they
are?

One more patch-generation point.  I notice that the patch includes
some variable name changes and other stylistic changes to existing
code.  While there is nothing wrong with suggesting this kind of
change, we try to separate the style / formatting changes from the
changes that introduce new features or fix bugs.  That makes the diffs
and change logs easier to read.  So it would be good to remove those
changes from the patch.

Checkstyle will flag this, but two other little things I noticed are
the presence of tabs (we use spaces in place of tabs) and if - then -
else with no braces (we like braces).

Thanks again for your interest and contributions!

Phil

On 10/11/07, Bradford Cross <bradford.n.cross@gmail.com> wrote:
> Cool - first patch finally submitted. :-)
>
> On 10/6/07, Phil Steitz <phil.steitz@gmail.com> wrote:
> >
> > On 10/3/07, Bradford Cross <bradford.n.cross@gmail.com> wrote:
> > > OK, I have created a patch...I tried to follow the instructions to file
> > a
> > > bug on bugzilla but i can't seem to find the right place to file a new
> > bug
> > > to either commons or commons math.
> > >
> > > I wonder if someone could help me out.
> > >
> >
> > Sorry for the response latency and sorry if you were led to Bugzilla
> > by the incorrect link that I just noticed on
> > http://commons.apache.org/math/developers.html.  I will fix that.
> >
> > We now use Jira for issue tracking / patch submission.  Here is a link
> > to the commons math issues page:
> >
> > http://commons.apache.org/math/issue-tracking.html
> >
> > Phil
> > >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> > For additional commands, e-mail: dev-help@commons.apache.org
> >
> >
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message