commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject Re: Trouble with commons-math
Date Wed, 31 Oct 2007 11:41:21 GMT
On 31/10/2007, Brent Worden <brent.worden@gmail.com> wrote:
> David,
>
> I just checked in a SynchronizedDescriptiveStatistics class that
> should eliminate the threading issues you're experiencing.  Feel free
> to grab it out of source control and give it a try.
>
> http://svn.apache.org/viewvc/commons/proper/math/trunk/src/java/org/apache/commons/math/stat/descriptive/SynchronizedDescriptiveStatistics.java?view=markup
>
>
> Other interested [math] parties,
>
> To insure I didn't miss anything in my implementation, feel free to
> look over this latest addition and critique it.

There are some spelling mistakes in the class description ;-)

It might be useful to add the annotation @ThreadSafe to the class,
e.g. as a comment:

/* @ThreadSafe */
public class ...

However, I'm not sure that the class is thread-safe.
For example the windowSize field is not final, and therefore may not
be visible to all threads after construction. Making it final would
fix this.

Fixing the eDA field might be tricky.

> Thanks,
>
> Brent.
>
> On Oct 28, 2007 3:42 AM, Torsten Curdt <tcurdt@apache.org> wrote:
> > Sounds like a threading issue. I'd assume DescriptiveStatistics is
> > not thread-safe and in your stacktrace I see
> >
> > >       at no.mypackage.spring.utils.ExecutionTimeAdviceTest$1.run
> > > (ExecutionTimeAdviceTest.java:47)
> > >       at EDU.oswego.cs.dl.util.concurrent.PooledExecutor$Worker.run
> > > (Unknown Source)
> > >       at java.lang.Thread.run(Thread.java:479)
> >
> > Try to synchronize access to the DescriptiveStatistics
> >
> > cheers
> > --
> > Torsten
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> > For additional commands, e-mail: dev-help@commons.apache.org
> >
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message