Mailing-List: contact commons-dev-help@jakarta.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Jakarta Commons Developers List" <commons-dev@jakarta.apache.org>
Received-SPF: pass (herse.apache.org: local policy)
Mime-Version: 1.0 (Apple Message framework v752.3)
In-Reply-To: <8a81b4af0707192233k655c7679gfeca1ec14cfc0e6b@mail.gmail.com>
References: <20070718064621.9223A1A981A@eris.apache.org>
 <8a81b4af0707192233k655c7679gfeca1ec14cfc0e6b@mail.gmail.com>
Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed
Message-Id: <8AF79E7E-751A-4206-9145-AC25E50D0179@iq80.com>
Content-Transfer-Encoding: 7bit
From: Dain Sundstrom <dain@iq80.com>
Subject: Re: svn commit: r557176 - in /jakarta/commons/proper/dbcp/trunk:
 src/java/org/apache/commons/dbcp/
 src/java/org/apache/commons/dbcp/cpdsadapter/
 src/test/org/apache/commons/dbcp/ src/test/org/apache/commons/dbcp/managed/
 xdocs/
Date: Thu, 19 Jul 2007 23:22:10 -0700
To: "Jakarta Commons Developers List" <commons-dev@jakarta.apache.org>

I think passivate() is called automatically when the connection is  
put back in the pool (due to the _conn.close() call).  I think there  
are tests that check that the statements were closed when the  
connection is closed.

Anyway, I don't think it is a big deal to call passivate twice.  It  
used to cause a SQLException because the delegating statements would  
throw an exception on the second close.

-dain


On Jul 19, 2007, at 10:33 PM, Phil Steitz wrote:

> Sorry I missed this in initial review.  I am not sure we want to
> remove the passivate() below, since that closes statements traced by
> this connection.  Am I missing something here?
>
> Phil
>
> jakarta/commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp/ 
> DelegatingConnection.java
> Tue Jul 17 23:46:16 2007
>> @@ -208,10 +208,17 @@
>>       * Closes the underlying connection, and close
>>       * any Statements that were not explicitly closed.
>>       */
>> -    public void close() throws SQLException
>> -    {
>> -        passivate();
>> -        _conn.close();
>> +    public void close() throws SQLException {
>> +        // close can be called multiple times, but  
>> PoolableConnection improperly
>> +        // throws an exception when a connection is closed twice,  
>> so before calling
>> +        // close we aren't alreayd closed
>> +        if (!isClosed()) {
>> +            try {
>> +                _conn.close();
>> +            } finally {
>> +                _closed = true;
>> +            }
>> +        }
>>      }
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: commons-dev-help@jakarta.apache.org
>


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org