commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Phil Steitz" <phil.ste...@gmail.com>
Subject Re: svn commit: r557176 - in /jakarta/commons/proper/dbcp/trunk: src/java/org/apache/commons/dbcp/ src/java/org/apache/commons/dbcp/cpdsadapter/ src/test/org/apache/commons/dbcp/ src/test/org/apache/commons/dbcp/managed/ xdocs/
Date Fri, 20 Jul 2007 05:33:21 GMT
Sorry I missed this in initial review.  I am not sure we want to
remove the passivate() below, since that closes statements traced by
this connection.  Am I missing something here?

Phil

jakarta/commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp/DelegatingConnection.java
Tue Jul 17 23:46:16 2007
> @@ -208,10 +208,17 @@
>       * Closes the underlying connection, and close
>       * any Statements that were not explicitly closed.
>       */
> -    public void close() throws SQLException
> -    {
> -        passivate();
> -        _conn.close();
> +    public void close() throws SQLException {
> +        // close can be called multiple times, but PoolableConnection improperly
> +        // throws an exception when a connection is closed twice, so before calling
> +        // close we aren't alreayd closed
> +        if (!isClosed()) {
> +            try {
> +                _conn.close();
> +            } finally {
> +                _closed = true;
> +            }
> +        }
>      }

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message