commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Phil Steitz (JIRA)" <j...@apache.org>
Subject [jira] Resolved: (DBCP-5) [dbcp] PoolGuardConnectionWrapper violates close() contract
Date Thu, 19 Jul 2007 04:14:05 GMT

     [ https://issues.apache.org/jira/browse/DBCP-5?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Phil Steitz resolved DBCP-5.
----------------------------

    Resolution: Fixed

Fixed in r 557176.

> [dbcp] PoolGuardConnectionWrapper violates close() contract
> -----------------------------------------------------------
>
>                 Key: DBCP-5
>                 URL: https://issues.apache.org/jira/browse/DBCP-5
>             Project: Commons Dbcp
>          Issue Type: Bug
>         Environment: Operating System: All
> Platform: All
>            Reporter: Derek Park
>             Fix For: 1.3
>
>
> org.apache.commons.dbcp.PoolingDatasource.PoolGuardConnectionWrapper.close()
> violates the Connection.close() contract specified in the Java 1.5 API.  The
> current API specifies that calling close() on an already-closed connection is a
> no-op.  (Blame Sun for the bug.  The API didn't used to say that.)  
> PoolGuardConnectionWrapper.close() first calls checkOpen() which throws an
> exception if close() has already been called.  Clearly that's not a no-op.
> The simplest fix is to change the first line in the close() method from this:
> checkOpen();
> to this:
> if (this.delegate == null) return;
> As of today (2006-03-22) this bug is in the latest SVN source (and has been in
> previous versions as well).
> DelegatingConnection and PoolingConnection don't seem (from a quick glance) to
> have this problem.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message