commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matt Benson (JIRA)" <j...@apache.org>
Subject [jira] Issue Comment Edited: (JXPATH-91) KeyManager should support nodeset selection
Date Wed, 04 Jul 2007 15:28:05 GMT

    [ https://issues.apache.org/jira/browse/JXPATH-91?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12510214
] 

Matt Benson edited comment on JXPATH-91 at 7/4/07 8:27 AM:
-----------------------------------------------------------

This looks reasonable.  A couple of issues with your source patch:

 - You have changed the signature of the protected functionKey() method in CoreFunction. 
All the followup code from computeValue() should be moved there and the signature preserved.

 - I see no need for NodePointer to implement getNodeSetByKey(); the JXPathContext is available
in functionKey() so the method defined on the context should be sufficient.


 was:
This looks reasonable.  A couple of points with your source patch:

 - You have changed the signature of the protected functionKey() method in CoreFunction. 
All the followup code from computeValue() should be moved there and the signature preserved.

 - I see no need for NodePointer to implement the selectNodeSet... method; the JXPathContext
is available in functionKey() so the method defined on the context should be sufficient.

> KeyManager should support nodeset selection
> -------------------------------------------
>
>                 Key: JXPATH-91
>                 URL: https://issues.apache.org/jira/browse/JXPATH-91
>             Project: Commons JXPath
>          Issue Type: Improvement
>    Affects Versions: 1.2 Final
>            Reporter: Sergey Vladimirov
>         Attachments: source-patch.txt, testcase-patch.txt
>
>
> KeyManager should support nodeset selection.
> In XSLT standart key() function can return not only singl node, but node set.
> KeyManager should support such functionality

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message