commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dain Sundstrom <d...@iq80.com>
Subject Re: [DBCP] Remove SQLNestedException
Date Tue, 24 Jul 2007 17:36:02 GMT
On Jul 24, 2007, at 7:56 AM, Phil Steitz wrote:

> On 7/23/07, Dain Sundstrom <dain@iq80.com> wrote:
>> DBCP-143 talks about problem with propagation of SQLNestedException
>> to clients and the comment suggests a conversion to normal Java
>> nested exception when we switch to Java 1.4.  Since we made the leap,
>> I did a bit of refactoring to remove this exception class.  Basically
>> I replace:
>>
>>    new SQLNestedException(msg, e);
>>
>> with:
>>
>>    (SQLException) new SQLException(msg).initCause(e);
>>
>> I attached this at a patch to 143 as I'm not 100% sure we want to go
>> this direction.
>>
>> So, should we drop SQLNestedException?
>
> This is tempting, but it breaks backward compatibility, so we should
> probably deprecate in 1.3 and remove in the next major release.  I
> guess the deprecation warning / release notes should just tell people
> to remove "legacy" casts in client code, since we never advertise this
> exception.

Sounds good.  I marked the class as deprecated, moved DBCP-143 to  
1.4, and added a note to the change log.

-dain

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message