Mailing-List: contact commons-dev-help@jakarta.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Jakarta Commons Developers List" <commons-dev@jakarta.apache.org>
Received-SPF: pass (herse.apache.org: domain of phil.steitz@gmail.com
 designates 66.249.92.169 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=beta;
        h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
        b=F0xfeXhgHF2VIwUFV7EsC7qxUPRB2LoJBMKZo677JhxBczd5Q/BDVcJL2LGxhwC3AxMxHtVEMgSdh71tWG1iuitivdj45h+eZX/xlR+9e58LGijBrlDK6Lx2EgdklxVcTKRS5gpjCgUHVf8U6/UBZ+pNrLnpJhsnuc7zGjfSqU0=
Message-ID: <8a81b4af0706101452i7013e27elc7b09b04d9cee3c1@mail.gmail.com>
Date: Sun, 10 Jun 2007 14:52:15 -0700
From: "Phil Steitz" <phil.steitz@gmail.com>
To: "Jakarta Commons Developers List" <commons-dev@jakarta.apache.org>
Subject: Re: svn commit: r545192 - in /jakarta/commons/proper/math/trunk/src:
 java/org/apache/commons/math/distribution/
 test/org/apache/commons/math/distribution/
In-Reply-To: <20070607143510.22E131A981A@eris.apache.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <20070607143510.22E131A981A@eris.apache.org>

>  public abstract class DistributionFactory {
>      /**
> @@ -59,16 +59,7 @@
>       * @return a new factory.
>       */
>      public static DistributionFactory newInstance() {
> -        DistributionFactory factory = null;
> -        try {
> -            DiscoverClass dc = new DiscoverClass();
> -            factory = (DistributionFactory) dc.newInstance(
> -                DistributionFactory.class,
> -                "org.apache.commons.math.distribution.DistributionFactoryImpl");
> -        } catch(Throwable t) {
> -            return new DistributionFactoryImpl();
> -        }
> -        return factory;
> +        return new DistributionFactoryImpl();
>      }
>
>      /**

This will break anyone who is actually using the commons-discovery
method to provide a custom factory - i.e., upgrading to 1.2 will
result in the custom config being ignored.

If done everywhere else, the above change also allows us to eliminate
compile-time dependency on [discovery] and [logging].  The alternative
is to leave the old code alone inside the now deprecated class and
remove altogether in 2.0.

I guess I am OK with this, since I doubt there are many users actually
depending on this and we can doc the changed behavior.  Other
opinions?

Phil

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org