commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Phil Steitz" <phil.ste...@gmail.com>
Subject Re: svn commit: r545192 - in /jakarta/commons/proper/math/trunk/src: java/org/apache/commons/math/distribution/ test/org/apache/commons/math/distribution/
Date Sun, 10 Jun 2007 21:52:15 GMT
>  public abstract class DistributionFactory {
>      /**
> @@ -59,16 +59,7 @@
>       * @return a new factory.
>       */
>      public static DistributionFactory newInstance() {
> -        DistributionFactory factory = null;
> -        try {
> -            DiscoverClass dc = new DiscoverClass();
> -            factory = (DistributionFactory) dc.newInstance(
> -                DistributionFactory.class,
> -                "org.apache.commons.math.distribution.DistributionFactoryImpl");
> -        } catch(Throwable t) {
> -            return new DistributionFactoryImpl();
> -        }
> -        return factory;
> +        return new DistributionFactoryImpl();
>      }
>
>      /**

This will break anyone who is actually using the commons-discovery
method to provide a custom factory - i.e., upgrading to 1.2 will
result in the custom config being ignored.

If done everywhere else, the above change also allows us to eliminate
compile-time dependency on [discovery] and [logging].  The alternative
is to leave the old code alone inside the now deprecated class and
remove altogether in 2.0.

I guess I am OK with this, since I doubt there are many users actually
depending on this and we can doc the changed behavior.  Other
opinions?

Phil

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message