commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stephen Colebourne (JIRA)" <j...@apache.org>
Subject [jira] Commented: (COLLECTIONS-255) Unused variable in TreeBidiMap.java
Date Fri, 08 Jun 2007 12:37:26 GMT

    [ https://issues.apache.org/jira/browse/COLLECTIONS-255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12502770
] 

Stephen Colebourne commented on COLLECTIONS-255:
------------------------------------------------

As a general rule, collections implementations use (b).

> Unused variable in TreeBidiMap.java
> -----------------------------------
>
>                 Key: COLLECTIONS-255
>                 URL: https://issues.apache.org/jira/browse/COLLECTIONS-255
>             Project: Commons Collections
>          Issue Type: Bug
>          Components: BidiMap
>    Affects Versions: Nightly Builds
>            Reporter: Henri Yandell
>            Priority: Trivial
>             Fix For: 3.3
>
>
> Twice in TreeBidiMap there is an entrySet variable that is not used. Rather the entrySet()
method returns a new TreeView every time.
> We should either:
> a) Delete the variable.
> b) Use the variable and always return the same TreeView.
> I'm thinking a).
> [Found via http://opensource.fortifysoftware.com/ ]

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message