Return-Path: Delivered-To: apmail-jakarta-commons-dev-archive@www.apache.org Received: (qmail 9736 invoked from network); 19 Apr 2007 15:29:39 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 19 Apr 2007 15:29:39 -0000 Received: (qmail 35289 invoked by uid 500); 19 Apr 2007 15:29:43 -0000 Delivered-To: apmail-jakarta-commons-dev-archive@jakarta.apache.org Received: (qmail 35228 invoked by uid 500); 19 Apr 2007 15:29:43 -0000 Mailing-List: contact commons-dev-help@jakarta.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Help: List-Post: List-Id: "Jakarta Commons Developers List" Reply-To: "Jakarta Commons Developers List" Delivered-To: mailing list commons-dev@jakarta.apache.org Received: (qmail 35213 invoked by uid 99); 19 Apr 2007 15:29:43 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 19 Apr 2007 08:29:43 -0700 X-ASF-Spam-Status: No, hits=-100.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO brutus.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 19 Apr 2007 08:29:36 -0700 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id BF6E0714069 for ; Thu, 19 Apr 2007 08:29:15 -0700 (PDT) Message-ID: <18887480.1176996555781.JavaMail.jira@brutus> Date: Thu, 19 Apr 2007 08:29:15 -0700 (PDT) From: "Niall Pemberton (JIRA)" To: commons-dev@jakarta.apache.org Subject: [jira] Created: (JCI-46) Add Guard conditions to logging statements MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org Add Guard conditions to logging statements ------------------------------------------ Key: JCI-46 URL: https://issues.apache.org/jira/browse/JCI-46 Project: Commons JCI Issue Type: Improvement Components: compiler eclipse, compiler groovy, compiler janino, compiler javac, compiler jsr199, compiler jython, compiler rhino, core, fam Affects Versions: 1.0RC2 Reporter: Niall Pemberton Priority: Minor The lack of Guard conditions on logging statements that concatenate objects to create the logging output results in unecessary StringBuffer creation when the logging level is below the threshold set. Would be a good idea IMO to change statements like: log.debug(getId() + " found class: " + name + " (" + clazzBytes.length + " bytes)"); to if (log.isDebugEnabled()) { log.debug(getId() + " found class: " + name + " (" + clazzBytes.length + " bytes)"); } -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. --------------------------------------------------------------------- To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org For additional commands, e-mail: commons-dev-help@jakarta.apache.org