commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hanson Char (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LANG-329) Pointless synchronized in ThreadLocal.initialValue should be removed
Date Fri, 20 Apr 2007 15:11:15 GMT

    [ https://issues.apache.org/jira/browse/LANG-329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12490381
] 

Hanson Char commented on LANG-329:
----------------------------------

%s/There is shared state/There is no shared state/g

> Pointless synchronized in ThreadLocal.initialValue should be removed
> --------------------------------------------------------------------
>
>                 Key: LANG-329
>                 URL: https://issues.apache.org/jira/browse/LANG-329
>             Project: Commons Lang
>          Issue Type: Improvement
>    Affects Versions: 2.3
>         Environment: Any
>            Reporter: Hanson Char
>            Priority: Trivial
>             Fix For: 3.0
>
>
> --- jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/builder/ToStringStyle.java
2007/01/27 07:13:59	500497
> +++ jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/builder/ToStringStyle.java
2007/04/20 05:06:03	530645
> @@ -103,7 +103,7 @@
>       * </p>
>       */
>      private static ThreadLocal registry = new ThreadLocal() {
> -        protected synchronized Object initialValue() {
> +        protected Object initialValue() {
>              // The HashSet implementation is not synchronized,
>              // which is just what we need here.
>              return new HashSet();
> --- jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/builder/HashCodeBuilder.java
2006/09/19 21:58:11	447989
> +++ jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/builder/HashCodeBuilder.java
2007/04/20 05:11:46	530648
> @@ -103,7 +103,7 @@
>       * @since 2.3
>       */
>      private static ThreadLocal registry = new ThreadLocal() {
> -        protected synchronized Object initialValue() {
> +        protected Object initialValue() {
>              // The HashSet implementation is not synchronized,
>              // which is just what we need here.
>              return new HashSet();

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message