Return-Path: Delivered-To: apmail-jakarta-commons-dev-archive@www.apache.org Received: (qmail 27842 invoked from network); 3 Mar 2007 20:45:25 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 3 Mar 2007 20:45:25 -0000 Received: (qmail 12290 invoked by uid 500); 3 Mar 2007 20:45:32 -0000 Delivered-To: apmail-jakarta-commons-dev-archive@jakarta.apache.org Received: (qmail 12220 invoked by uid 500); 3 Mar 2007 20:45:32 -0000 Mailing-List: contact commons-dev-help@jakarta.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Help: List-Post: List-Id: "Jakarta Commons Developers List" Reply-To: "Jakarta Commons Developers List" Delivered-To: mailing list commons-dev@jakarta.apache.org Received: (qmail 12209 invoked by uid 99); 3 Mar 2007 20:45:32 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 03 Mar 2007 12:45:32 -0800 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (herse.apache.org: domain of rahul.akolkar@gmail.com designates 209.85.132.245 as permitted sender) Received: from [209.85.132.245] (HELO an-out-0708.google.com) (209.85.132.245) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 03 Mar 2007 12:45:22 -0800 Received: by an-out-0708.google.com with SMTP id c14so934668anc for ; Sat, 03 Mar 2007 12:45:01 -0800 (PST) DKIM-Signature: a=rsa-sha1; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=jziGiv0Q0nUUny2m3+sf2xKf/jFWwrlacdSzgmly35wmvYKQFzN8n2owBBMkIZD5gPByAvzhvTmhQXlnQslBBsVbOp0HdZR0F7jvycXykhk/bYYjtdrAdh+c+/Lghu1APvrmRxJoGXM+CLaTkxUeJbq7nTYVYLq27U8S4qb91Os= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=e7U0sTz30zsggCegCeBs6SxX+kHKLAtD9Pe9ZSx1nxd/u6Uv2qb2M+Din1YXq2i1HC5gga3FYGSgd8HwELWZyRiQ6aixGTcAnht/UoMxq/w8x2WlcVAHUNrd0v4cbFgK6qzuMbqhUKNNQl2fsBwr2NflgNpVOUJ076cfUHO61qo= Received: by 10.114.25.3 with SMTP id 3mr746146way.1172954700494; Sat, 03 Mar 2007 12:45:00 -0800 (PST) Received: by 10.114.234.18 with HTTP; Sat, 3 Mar 2007 12:45:00 -0800 (PST) Message-ID: Date: Sat, 3 Mar 2007 15:45:00 -0500 From: "Rahul Akolkar" To: "Jakarta Commons Developers List" Subject: Re: [email] svn commit: r510708 - in /jakarta/commons/proper/email/trunk/src: java/org/apache/commons/mail/HtmlEmail.java test/org/apache/commons/mail/HtmlEmailTest.java test/org/apache/commons/mail/mocks/MockHtmlEmailConcrete.java In-Reply-To: <20070222233526.DC8621A981A@eris.apache.org> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20070222233526.DC8621A981A@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org On 2/22/07, dion@apache.org wrote: > Author: dion > Date: Thu Feb 22 15:35:23 2007 > New Revision: 510708 > > URL: http://svn.apache.org/viewvc?view=rev&rev=510708 > Log: > EMAIL-50 HTML Emails with images don't display in Outlook 2000 > > Modified: > jakarta/commons/proper/email/trunk/src/java/org/apache/commons/mail/HtmlEmail.java > jakarta/commons/proper/email/trunk/src/test/org/apache/commons/mail/HtmlEmailTest.java > jakarta/commons/proper/email/trunk/src/test/org/apache/commons/mail/mocks/MockHtmlEmailConcrete.java > > Modified: jakarta/commons/proper/email/trunk/src/java/org/apache/commons/mail/HtmlEmail.java > URL: http://svn.apache.org/viewvc/jakarta/commons/proper/email/trunk/src/java/org/apache/commons/mail/HtmlEmail.java?view=diff&rev=510708&r1=510707&r2=510708 > ============================================================================== > --- jakarta/commons/proper/email/trunk/src/java/org/apache/commons/mail/HtmlEmail.java (original) > +++ jakarta/commons/proper/email/trunk/src/java/org/apache/commons/mail/HtmlEmail.java Thu Feb 22 15:35:23 2007 > @@ -20,9 +20,9 @@ > import java.io.InputStream; > import java.net.MalformedURLException; > import java.net.URL; > -import java.util.ArrayList; > +import java.util.HashMap; > import java.util.Iterator; > -import java.util.List; > +import java.util.Map; > > import javax.activation.DataHandler; > import javax.activation.URLDataSource; > @@ -69,8 +69,11 @@ > /** Html part of the message */ > protected String html; > > - /** Embedded images */ > - protected List inlineImages = new ArrayList(); > + /** > + * Embedded images Map where the key is the > + * user-defined image name > + */ > + protected Map inlineImages = new HashMap(); > EMAIL-50 has a fix version of 1.1, could break subclasses? -Rahul --------------------------------------------------------------------- To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org For additional commands, e-mail: commons-dev-help@jakarta.apache.org