commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jochen Wiedmann (JIRA)" <>
Subject [jira] Commented: (IO-116) Replace static FileCleaner methods
Date Sun, 04 Mar 2007 17:22:50 GMT


Jochen Wiedmann commented on IO-116:

Holger, I may get things wrong, but IMO you are perfectly capable of controlling the threads

- You create your own instance of FileCleaningTracker.
- The thread is started whenever the first file is added to the instance as trackable.
- The thread may be terminated by invoking exitWhenFinished().

For a new lifecycle, simply create a new instance. So, what's wrong in your opinion?

> Replace static FileCleaner methods
> ----------------------------------
>                 Key: IO-116
>                 URL:
>             Project: Commons IO
>          Issue Type: Improvement
>          Components: Utilities
>    Affects Versions: 1.3.1
>            Reporter: Jochen Wiedmann
>            Priority: Critical
>             Fix For: 1.4
>         Attachments: commons-io-filecleaningtracker.patch
> The attached patch aims to finally resolve the problems, which are named in IO-99, FILEUPLOAD-120,
> I choosed a conservative strategy: Basically I copied the FileCleaner class to an instantiable
class FileCleaningTracker with instance methods. The static FileCleaner methods are now implemented
by a static instance of FileCleaningTracker. (The name FileCleaningTracker is, of course,
> The FileCleaningTestCase was also created by simply copying FileCleaner to FileCleaningTestCase.
FileCleanerTestCase is now similarly implemented as a subclass of FileCleanerTestCase which
uses the static instance of FileCleaner rather than a dynamically created instance.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message