Return-Path: Delivered-To: apmail-jakarta-commons-dev-archive@www.apache.org Received: (qmail 85101 invoked from network); 1 Feb 2007 09:45:29 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 1 Feb 2007 09:45:29 -0000 Received: (qmail 38883 invoked by uid 500); 1 Feb 2007 09:45:35 -0000 Delivered-To: apmail-jakarta-commons-dev-archive@jakarta.apache.org Received: (qmail 38367 invoked by uid 500); 1 Feb 2007 09:45:33 -0000 Mailing-List: contact commons-dev-help@jakarta.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Help: List-Post: List-Id: "Jakarta Commons Developers List" Reply-To: "Jakarta Commons Developers List" Delivered-To: mailing list commons-dev@jakarta.apache.org Received: (qmail 38256 invoked by uid 99); 1 Feb 2007 09:45:33 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 01 Feb 2007 01:45:33 -0800 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO brutus.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 01 Feb 2007 01:45:26 -0800 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 1BA897142E4 for ; Thu, 1 Feb 2007 01:45:06 -0800 (PST) Message-ID: <15856271.1170323106110.JavaMail.jira@brutus> Date: Thu, 1 Feb 2007 01:45:06 -0800 (PST) From: =?utf-8?Q?Holger_Hoffst=C3=A4tte_=28JIRA=29?= To: commons-dev@jakarta.apache.org Subject: [jira] Commented: (LANG-260) StringEscapeUtils should expose escape*() methods taking Writer argument In-Reply-To: <14526929.1149051989880.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/LANG-260?page=3Dcom.atlassian.j= ira.plugin.system.issuetabpanels:comment-tabpanel#action_12469387 ]=20 Holger Hoffst=C3=A4tte commented on LANG-260: ---------------------------------------- StringWriter is just a glorified StringBuffer and has exactly no performanc= e advantage to a correctly presized StringBuffer. I think the refactoring d= one for this has undone what I just commented on in LANG-287. > StringEscapeUtils should expose escape*() methods taking Writer argument > ------------------------------------------------------------------------ > > Key: LANG-260 > URL: https://issues.apache.org/jira/browse/LANG-260 > Project: Commons Lang > Issue Type: Improvement > Environment: N/A > Reporter: Norval Hope > Fix For: 2.2 > > > StringEscapeUtils.escapeXML(String) is the only exposed variant, but the = package private Entities.XML class it uses under the covers has a variant t= aking a Writer. The StringEscapeUtils.escapeXML(Writer, String) variant wou= ld be much more efficient when incrementally escaping values and adding the= m one-by-one and could seemingly be exposed with very little effort. Ditto = for the unescapeXML() case, and presumably other styles of escape/unescape = (like HTML) that use the Entities class under the covers. --=20 This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. --------------------------------------------------------------------- To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org For additional commands, e-mail: commons-dev-help@jakarta.apache.org