commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jörg Schaible <joerg.schai...@gmx.de>
Subject Re: [VOTE] Release commons-fileupload 1.2 (4th attempt)
Date Fri, 16 Feb 2007 17:31:36 GMT
Oliver Heger wrote:

> Two minor points:
> 
> (1) The md5 files do not contain the file name, which is standard for
> commons components (see section 2 of [1]).

This is the way Maven 2 generates *and* checks it. So if you change those, I
am quite sure, that every M2 user will get always a warning because of the
checksum!

[snip]

> (2) In the jar generated by the ant build the LICENSE is missing.
> 
> (2) is probably less important for components that use maven as
> preferred build tool. I am not sure how important (1) is.
> 
> Otherwise everything looks good. So I am +1 when (1) is fixed.

If every user gets a warning when this is fixed, I am -1 on this fix :D

[snip]

- Jörg


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message