commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jörg Schaible <joerg.schai...@gmx.de>
Subject Re: [VOTE] Release Commons DBCP 1.2.2
Date Thu, 15 Feb 2007 21:08:45 GMT
Hi Phil,

sorry I am late and I downloaded the source package, compiled and run all
tests in Gentoo Linux with Maven for Sun JDK 1.4.2, Sun JDK 1.5.0,
Blackdown JDK 1.4.2_03, IBM JDK 1.4.2.7, and IBM JDK 1.5.0.3 and all tests
run fine for these.

It fails for JRockit 1.4.2.11 and 1.5.0.6 though with:
============================== %< ==================
Testsuite: org.apache.commons.dbcp.TestBasicDataSource
Tests run: 33, Failures: 1, Errors: 0, Time elapsed: 4,364 sec

Testcase:
testCreateDataSourceCleanupThreads(org.apache.commons.dbcp.TestBasicDataSource):
FAILED
expected:<1> but was:<2>
junit.framework.AssertionFailedError: expected:<1> but was:<2>
        at
org.apache.commons.dbcp.TestBasicDataSource.testCreateDataSourceCleanupThreads(TestBasicDataSource.java:334)
        at jrockit.reflect.VirtualNativeMethodInvoker.invoke(Ljava.lang.Object
[Ljava.lang.Object;)Ljava.lang.Object;(Unknown Source)
============================== %< ==================

Additionally, you've realized that the complete package is no longer
compatible with JDK 6? I don't know what we can really do about it, since
the new JDBC version defines a lot of new methods for java.sql.Statement
and java.sql.Connection and - even worse - some of those methods have
arguments or return values only avalable in JDK 6.

Unless someone comes up with a really clever solution, there's nothing we
can do about it and this is not even documented somewhere in the release.

- Jörg

============================== %< ==================
java:compile:
    [echo] Compiling
to /home/joehni/java/commons-dbcp-1.2.2-src/target/classes
    [javac] Compiling 41 source files
to /home/joehni/java/commons-dbcp-1.2.2-src/target/classes
/home/joehni/java/commons-dbcp-1.2.2-src/src/java/org/apache/commons/dbcp/DelegatingStatement.java:46:
org.apache.commons.dbcp.DelegatingStatement is not abstract and does not
override abstract method isPoolable() in java.sql.Statement
public class DelegatingStatement extends AbandonedTrace implements Statement
{
       ^
/home/joehni/java/commons-dbcp-1.2.2-src/src/java/org/apache/commons/dbcp/DelegatingStatement.java:131:
isClosed() in org.apache.commons.dbcp.DelegatingStatement cannot implement
isClosed() in java.sql.Statement; attempting to assign weaker access
privileges; was public
    protected boolean isClosed() {
                      ^
/home/joehni/java/commons-dbcp-1.2.2-src/src/java/org/apache/commons/dbcp/DelegatingPreparedStatement.java:50:
org.apache.commons.dbcp.DelegatingPreparedStatement is not abstract and
does not override abstract method setNClob(int,java.io.Reader) in
java.sql.PreparedStatement
public class DelegatingPreparedStatement extends DelegatingStatement
       ^
/home/joehni/java/commons-dbcp-1.2.2-src/src/java/org/apache/commons/dbcp/PoolablePreparedStatement.java:41:
org.apache.commons.dbcp.PoolablePreparedStatement is not abstract and does
not override abstract method setNClob(int,java.io.Reader) in
java.sql.PreparedStatement
public class PoolablePreparedStatement extends DelegatingPreparedStatement
implements PreparedStatement {
       ^
/home/joehni/java/commons-dbcp-1.2.2-src/src/java/org/apache/commons/dbcp/cpdsadapter/PoolablePreparedStatementStub.java:34:
isClosed() in org.apache.commons.dbcp.DelegatingStatement cannot implement
isClosed() in java.sql.Statement; attempting to assign weaker access
privileges; was public
class PoolablePreparedStatementStub extends PoolablePreparedStatement {
^
/home/joehni/java/commons-dbcp-1.2.2-src/src/java/org/apache/commons/dbcp/DelegatingConnection.java:51:
org.apache.commons.dbcp.DelegatingConnection is not abstract and does not
override abstract method createStruct(java.lang.String,java.lang.Object[])
in java.sql.Connection
public class DelegatingConnection extends AbandonedTrace
       ^
/home/joehni/java/commons-dbcp-1.2.2-src/src/java/org/apache/commons/dbcp/cpdsadapter/PooledConnectionImpl.java:43:
org.apache.commons.dbcp.cpdsadapter.PooledConnectionImpl is not abstract
and does not override abstract method
removeStatementEventListener(javax.sql.StatementEventListener) in
javax.sql.PooledConnection
class PooledConnectionImpl
^
/home/joehni/java/commons-dbcp-1.2.2-src/src/java/org/apache/commons/dbcp/cpdsadapter/ConnectionImpl.java:41:
org.apache.commons.dbcp.cpdsadapter.ConnectionImpl is not abstract and does
not override abstract method
createStruct(java.lang.String,java.lang.Object[]) in java.sql.Connection
class ConnectionImpl implements Connection {
^
/home/joehni/java/commons-dbcp-1.2.2-src/src/java/org/apache/commons/dbcp/datasources/PerUserPoolDataSource.java:52:
org.apache.commons.dbcp.datasources.PerUserPoolDataSource is not abstract
and does not override abstract method isWrapperFor(java.lang.Class) in
java.sql.Wrapper
public class PerUserPoolDataSource
       ^
/home/joehni/java/commons-dbcp-1.2.2-src/src/java/org/apache/commons/dbcp/datasources/SharedPoolDataSource.java:45:
org.apache.commons.dbcp.datasources.SharedPoolDataSource is not abstract
and does not override abstract method isWrapperFor(java.lang.Class) in
java.sql.Wrapper
public class SharedPoolDataSource
       ^
/home/joehni/java/commons-dbcp-1.2.2-src/src/java/org/apache/commons/dbcp/DelegatingCallableStatement.java:53:
org.apache.commons.dbcp.DelegatingCallableStatement is not abstract and
does not override abstract method setNClob(java.lang.String,java.io.Reader)
in java.sql.CallableStatement
public class DelegatingCallableStatement extends DelegatingPreparedStatement
       ^
/home/joehni/java/commons-dbcp-1.2.2-src/src/java/org/apache/commons/dbcp/DelegatingResultSet.java:55:
org.apache.commons.dbcp.DelegatingResultSet is not abstract and does not
override abstract method updateNClob(java.lang.String,java.io.Reader) in
java.sql.ResultSet
public class DelegatingResultSet extends AbandonedTrace implements ResultSet
{
       ^
/home/joehni/java/commons-dbcp-1.2.2-src/src/java/org/apache/commons/dbcp/PoolingConnection.java:42:
org.apache.commons.dbcp.PoolingConnection is not abstract and does not
override abstract method createStruct(java.lang.String,java.lang.Object[])
in java.sql.Connection
public class PoolingConnection extends DelegatingConnection implements
Connection, KeyedPoolableObjectFactory {
       ^
/home/joehni/java/commons-dbcp-1.2.2-src/src/java/org/apache/commons/dbcp/BasicDataSource.java:44:
org.apache.commons.dbcp.BasicDataSource is not abstract and does not
override abstract method isWrapperFor(java.lang.Class) in java.sql.Wrapper
public class BasicDataSource implements DataSource {
       ^
/home/joehni/java/commons-dbcp-1.2.2-src/src/java/org/apache/commons/dbcp/PoolingDataSource.java:45:
org.apache.commons.dbcp.PoolingDataSource is not abstract and does not
override abstract method isWrapperFor(java.lang.Class) in java.sql.Wrapper
public class PoolingDataSource implements DataSource {
       ^
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
15 errors

BUILD FAILED
File...... /home/joehni/.maven/cache/maven-java-plugin-1.5/plugin.jelly
Element... ant:javac
Line...... 63
Column.... 48
Compile failed; see the compiler error output for details.
Total time: 7 seconds
Finished at: Thu Feb 15 21:52:10 CET 2007
============================== %< ==================


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message