commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From d...@apache.org
Subject svn commit: r511703 - in /jakarta/commons/proper/email/trunk/src/test/org/apache/commons/mail: BaseEmailTestCase.java EmailAttachmentTest.java
Date Mon, 26 Feb 2007 02:45:24 GMT
Author: dion
Date: Sun Feb 25 18:45:23 2007
New Revision: 511703

URL: http://svn.apache.org/viewvc?view=rev&rev=511703
Log:
checkstyle fixes

Modified:
    jakarta/commons/proper/email/trunk/src/test/org/apache/commons/mail/BaseEmailTestCase.java
    jakarta/commons/proper/email/trunk/src/test/org/apache/commons/mail/EmailAttachmentTest.java

Modified: jakarta/commons/proper/email/trunk/src/test/org/apache/commons/mail/BaseEmailTestCase.java
URL: http://svn.apache.org/viewvc/jakarta/commons/proper/email/trunk/src/test/org/apache/commons/mail/BaseEmailTestCase.java?view=diff&rev=511703&r1=511702&r2=511703
==============================================================================
--- jakarta/commons/proper/email/trunk/src/test/org/apache/commons/mail/BaseEmailTestCase.java
(original)
+++ jakarta/commons/proper/email/trunk/src/test/org/apache/commons/mail/BaseEmailTestCase.java
Sun Feb 25 18:45:23 2007
@@ -68,11 +68,6 @@
     /** URL to used to test URL attachmetns (Must be valid) */
     protected String strTestURL = EmailConfiguration.TEST_URL;
 
-    protected int getMailServerPort()
-    {
-        return mailServerPort;
-    }
-
     /** Test characters acceptable to email */
     protected String[] testCharsValid =
     {
@@ -86,7 +81,7 @@
     };
 
     /** Array of test strings */
-    protected String[] testCharsNotValid = { "", null };
+    protected String[] testCharsNotValid = {"", null};
 
     /** Where to save email output **/
     private File emailOutputDir;
@@ -105,12 +100,6 @@
     }
 
     /** */
-    protected void setUp() throws Exception
-    {
-
-    }
-
-    /** */
     protected void tearDown()
     {
         //stop the fake email server (if started)
@@ -121,6 +110,15 @@
         }
 
         this.fakeMailServer = null;
+    }
+
+    /**
+     * Gets the mail server port.
+     * @return the port the server is running on.
+     */
+    protected int getMailServerPort()
+    {
+        return mailServerPort;
     }
 
     /**

Modified: jakarta/commons/proper/email/trunk/src/test/org/apache/commons/mail/EmailAttachmentTest.java
URL: http://svn.apache.org/viewvc/jakarta/commons/proper/email/trunk/src/test/org/apache/commons/mail/EmailAttachmentTest.java?view=diff&rev=511703&r1=511702&r2=511703
==============================================================================
--- jakarta/commons/proper/email/trunk/src/test/org/apache/commons/mail/EmailAttachmentTest.java
(original)
+++ jakarta/commons/proper/email/trunk/src/test/org/apache/commons/mail/EmailAttachmentTest.java
Sun Feb 25 18:45:23 2007
@@ -30,7 +30,7 @@
 public class EmailAttachmentTest extends BaseEmailTestCase
 {
     /** */
-    private EmailAttachment attachment = null;
+    private EmailAttachment attachment;
 
     /**
      * @param name name



---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message